Let users set a default calendar for new events #399

vgezer · 2014-04-09T21:27:49Z

This should implement: #348

Users can set one calendar default by clicking on the star.
New events will be created in the default calendar.

If none is set, the first created calendar is the default one.
Setting a calendar as default highlights the star
Only one star is highlighted, remove the old one (needed to see the changes immediately)
Clicking on the same calendar should not do anything
New default calendar is used when clicked on calendar to create new event
The first calendar is used if user deletes the default calendar

vgezer · 2014-04-12T13:00:35Z

Some screenshots:

Test 2 is selected as default:

Personal is selected as default:

georgehrke · 2014-04-12T13:01:12Z

cc @jancborchardt

jancborchardt · 2014-04-13T05:37:37Z

As this adds yet another control to the calendar rows, I’d say we need to solve first how we cope with 3+ control elements of that sort. Like introducing a caret/triangle to hint at more settings. And maybe have sharing always present (or whichever one we regard the most important action). And that should be done in core, in an apps.js (and existing apps.css).

@jbtbnl @Kondou-ger @MorrisJobke do you have proposals? Previously we talked about a bubble (not very well integrated), or expanding the row to expose options (well integrated as long as there is an animation). Anything else?

jbtbnl · 2014-04-13T09:20:15Z

@jancborchardt I believe that a lot of "settings" do not actually belong there. For instance the two CalDAV links, they should be on the "Help" page instead. There could be a link in the settings drawer "Learn how to setup CalDAV" to guide new users there.

The "Clear cache" button shouldn't be necessary or should be at a less prominent location.

The "Timezone" setting is a general setting like display language and should therefore be in the personal settings page. On ownCloud setup it should default corresponding to the user's language.

georgehrke · 2014-04-13T09:27:18Z

The "Clear cache" button shouldn't be necessary or should be at a less prominent location.

What about showing the clear cache button only when debug mode is enabled?

The "Timezone" setting is a general setting like display language and should therefore be in the personal settings page. On ownCloud setup it should default corresponding to the user's language.

We should get rid of the timezone setting anyhow. the calendar should just use the timezone of the browser.

jbtbnl · 2014-04-13T12:07:54Z

What about showing the clear cache button only when debug mode is enabled?

That could be, I can't judge if it's necessary that often while developing / debugging the Calendar app.

vgezer · 2014-04-13T12:21:23Z

@jancborchardt Like introducing a caret/triangle to hint at more settings.

I suggest using "..." as in Android or other mobile OSes.

LukasReschke · 2014-04-14T18:38:47Z

ajax/calendar/makedefault.php

+OCP\JSON::checkAppEnabled('calendar');
+OCP\JSON::callCheck();
+
+$cal = $_POST["calendarid"];


Should I modify this as well:

https://github.com/owncloud/calendar/blob/master/ajax/calendar/delete.php#L14

Go for it :-)

jancborchardt · 2014-04-15T09:52:23Z

@jbtbnl:

I believe that a lot of "settings" do not actually belong there. For instance the two CalDAV links, they should be on the "Help" page instead. There could be a link in the settings drawer "Learn how to setup CalDAV" to guide new users there.

No, all app-specific settings should be in the app. We previously had app settings on the personal page and it was confusing. As CalDAV is bound to the Calendar app, it should be in there. I agree that »Settings« might be a slightly misleading name, but I don’t think it’s a really grave issue.

The "Clear cache" button shouldn't be necessary or should be at a less prominent location.

Yes, we should remove it for good. @georgehrke can we please do that? Just showing it in debug is also fine with me for now.

The "Timezone" setting is a general setting like display language and should therefore be in the personal settings page. On ownCloud setup it should default corresponding to the user's language.

Yes. See the »global region format« issue in core: owncloud/core#376

vgezer · 2014-04-15T10:55:12Z

@LukasReschke Thanks :). I have committed again with the changes. Can you check it again?

georgehrke · 2014-04-20T18:19:14Z

@jancborchardt What's your final decision on this?

I agree that yet another control element is not good. A better solution would be to make the calendar list sortable. Users could make a calendar 'default' by moving it to the top of the list.

vgezer · 2014-04-20T18:43:42Z

@georgehrke Or maybe using the settings panel to pick the default calendar from dropdown list?

vgezer · 2014-05-04T23:11:44Z

@jancborchardt, what should we do with this?

jancborchardt · 2014-05-16T09:16:40Z

This is a good function, but we should wait with implementing it once we switch to the menu where items are extended downwards.

With the current solution of having icons next to it, we can’t just put function after function in there. Especially because in this case, the star icon is not very clear.

(Also, the ability to reorder calendars is a bit excessive to just get this solved, and is also not very discoverable that it defines the default calendar.)

So, we should wait with this. Hope that’s ok?

vgezer · 2014-05-19T11:56:36Z

@jancborchardt Yes sure. I will update it later after new menus :)

brantje · 2014-07-08T16:05:05Z

Rebased onto master

brantje · 2014-07-08T16:09:00Z

👍 tested in chrome / ff / chrome mobile

brantje · 2014-08-05T20:38:36Z

@jancborchardt why isn't this merged yet?

vgezer · 2014-08-06T11:57:30Z

@brantje Because we wanted to avoid using extra action button. See the Jan's comment above: owncloud/calendar#399 (comment)

jancborchardt · 2014-08-06T13:24:48Z

Yes, the sidebar is cluttered with actions at the moment. We need to clean that up before we add new stuff.

jbtbnl · 2014-08-27T10:30:27Z

Work in progress on the action buttons cleanup: owncloud/core#10644

vgezer · 2014-11-20T09:40:09Z

What do we do with this? Should I work on this so this gets merged?

jbtbnl · 2014-11-20T10:10:23Z

@wakeup since owncloud/core#10644 has been merged, it would be great if you could add the actions menu in this PR.

@jancborchardt should all actions be in the menu or are there some (like edit and share) that should remain visible?

jancborchardt · 2014-11-20T10:38:24Z

I’d say Share should remain visible, yes (just as planned for the Files app). It needs to be on half opacity though, and only be fully opaque when actually shared.

vgezer · 2014-11-20T11:28:08Z

@jbtbnl Just a quick question, does the current git version of Calendar work in your environments?

Similar to owncloud/core#12197 I am having this error when choosing Calendar app:

Fatal error: Uncaught exception 'Exception' with message 'js file not found: script:jquery.multiselect serverroot:/var/www/owncloud' in /var/www/owncloud/lib/private/template/resourcelocator.php:46 Stack trace: #0 /var/www/owncloud/lib/private/templatelayout.php(152): OC\Template\ResourceLocator->find(Array) #1 /var/www/owncloud/lib/private/templatelayout.php(103): OC_TemplateLayout::findJavascriptFiles(Array) #2 /var/www/owncloud/lib/private/template.php(118): OC_TemplateLayout->__construct('error', '') #3 /var/www/owncloud/lib/private/template/base.php(103): OC_Template->fetchPage() #4 /var/www/owncloud/lib/private/template.php(227): OC\Template\Base->printPage() #5 [internal function]: OC_Template::printExceptionErrorPage(Object(Exception)) #6 {main} thrown in /var/www/owncloud/lib/private/template/resourcelocator.php on line 46

jbtbnl · 2014-11-20T11:56:57Z

@wakeup Calendar master doesn't work because of owncloud/core#12005

georgehrke · 2014-11-23T10:34:51Z

@wakeup Calendar master doesn't work because of owncloud/core#12005

should be fixed with owncloud/calendar@59d249a

This should fix: #348 Users can set one calendar default by clicking on the star. New events will be created in the default calendar.

DeepDiver1975 · 2015-10-13T12:27:57Z

works 👍

DeepDiver1975 · 2015-10-13T12:28:18Z

anyhow moving to backlog because of open UX issues as declared above

vgezer added 5 - To review labels Apr 9, 2014

vgezer self-assigned this Apr 9, 2014

vgezer changed the title ~~Let users to set a default calendar for new events~~ Let users set a default calendar for new events Apr 9, 2014

vgezer changed the title ~~Let users set a default calendar for new events~~ [AWAITING REVIEW] Let users set a default calendar for new events Apr 11, 2014

LukasReschke reviewed Apr 14, 2014
View reviewed changes

georgehrke changed the title ~~[AWAITING REVIEW] Let users set a default calendar for new events~~ Let users set a default calendar for new events Apr 26, 2014

georgehrke added 1 - Backlog and removed 5 - To review labels Aug 7, 2014

georgehrke force-pushed the master branch from b5aefcc to a723bf9 Compare September 2, 2014 13:04

vgezer force-pushed the default-cal-selection branch from 2b93292 to 5521ed2 Compare November 20, 2014 11:35

vgezer mentioned this pull request Dec 6, 2014

Let users set a default calendar for new events [with hidden buttons] #639

Open

jancborchardt added 1 - to develop and removed 1 - Backlog labels Jul 1, 2015

Let users set a default calendar for new events

aee5b12

This should fix: #348 Users can set one calendar default by clicking on the star. New events will be created in the default calendar.

DeepDiver1975 force-pushed the default-cal-selection branch from 5521ed2 to aee5b12 Compare October 13, 2015 12:14

DeepDiver1975 added this to the backlog milestone Oct 13, 2015

Add missing route

8ea313b

vgezer removed their assignment Mar 1, 2016

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Let users set a default calendar for new events #399

Let users set a default calendar for new events #399

vgezer commented Apr 9, 2014

vgezer commented Apr 12, 2014

georgehrke commented Apr 12, 2014

jancborchardt commented Apr 13, 2014

jbtbnl commented Apr 13, 2014

georgehrke commented Apr 13, 2014

jbtbnl commented Apr 13, 2014

vgezer commented Apr 13, 2014

LukasReschke Apr 14, 2014

vgezer Apr 14, 2014

LukasReschke Apr 15, 2014

jancborchardt commented Apr 15, 2014

vgezer commented Apr 15, 2014

georgehrke commented Apr 20, 2014

vgezer commented Apr 20, 2014

vgezer commented May 4, 2014

jancborchardt commented May 16, 2014

vgezer commented May 19, 2014

brantje commented Jul 8, 2014

brantje commented Jul 8, 2014

brantje commented Aug 5, 2014

vgezer commented Aug 6, 2014

jancborchardt commented Aug 6, 2014

jbtbnl commented Aug 27, 2014

vgezer commented Nov 20, 2014

jbtbnl commented Nov 20, 2014

jancborchardt commented Nov 20, 2014

vgezer commented Nov 20, 2014

jbtbnl commented Nov 20, 2014

georgehrke commented Nov 23, 2014

DeepDiver1975 commented Oct 13, 2015

DeepDiver1975 commented Oct 13, 2015

Let users set a default calendar for new events #399

Are you sure you want to change the base?

Let users set a default calendar for new events #399

Conversation

vgezer commented Apr 9, 2014

vgezer commented Apr 12, 2014

georgehrke commented Apr 12, 2014

jancborchardt commented Apr 13, 2014

jbtbnl commented Apr 13, 2014

georgehrke commented Apr 13, 2014

jbtbnl commented Apr 13, 2014

vgezer commented Apr 13, 2014

LukasReschke Apr 14, 2014

Choose a reason for hiding this comment

vgezer Apr 14, 2014

Choose a reason for hiding this comment

LukasReschke Apr 15, 2014

Choose a reason for hiding this comment

jancborchardt commented Apr 15, 2014

vgezer commented Apr 15, 2014

georgehrke commented Apr 20, 2014

vgezer commented Apr 20, 2014

vgezer commented May 4, 2014

jancborchardt commented May 16, 2014

vgezer commented May 19, 2014

brantje commented Jul 8, 2014

brantje commented Jul 8, 2014

brantje commented Aug 5, 2014

vgezer commented Aug 6, 2014

jancborchardt commented Aug 6, 2014

jbtbnl commented Aug 27, 2014

vgezer commented Nov 20, 2014

jbtbnl commented Nov 20, 2014

jancborchardt commented Nov 20, 2014

vgezer commented Nov 20, 2014

jbtbnl commented Nov 20, 2014

georgehrke commented Nov 23, 2014

DeepDiver1975 commented Oct 13, 2015

DeepDiver1975 commented Oct 13, 2015