[FEATURE REQUEST] Open and create .url shortcut files #4420

Aitorbp · 2024-06-10T18:03:53Z

Related Issues

App: #4413

Add changelog files for the fixed issues in folder changelog/unreleased. More info here
Add feature to Release Notes in ReleaseNotesViewModel.kt creating a new ReleaseNote() with String resources (if required)

QA

Test plan: https://github.com/owncloud/QA/blob/master/Mobile/Android/Executions/Release_4.3/Shortcuts.md

Reports and improvements:

(1) Alignment with other platforms [FEATURE REQUEST] Open and create .url shortcut files #4420 (comment) [FIXED]
(2) .url next to the edit field [FEATURE REQUEST] Open and create .url shortcut files #4420 (comment) [FIXED]
(3) Limit to long names [FEATURE REQUEST] Open and create .url shortcut files #4420 (comment) [FIXED]
(4) Default protocol for shortcut [FEATURE REQUEST] Open and create .url shortcut files #4420 (comment) [FIXED]
(5) Icon in uploads view [FEATURE REQUEST] Open and create .url shortcut files #4420 (comment) [FIXED]
(6) Long names handling [FEATURE REQUEST] Open and create .url shortcut files #4420 (comment) [FIXED]
(7) use blanks instead of spaces in error message [FEATURE REQUEST] Open and create .url shortcut files #4420 (comment) [FIXED]

JuancaG05

Some questions and changes requested here @Aitorbp!

changelog/unreleased/4420

owncloudApp/src/main/res/values/strings.xml

owncloudApp/src/main/java/com/owncloud/android/extensions/ActivityExt.kt

.../java/com/owncloud/android/presentation/files/createshortcut/CreateShortcutDialogFragment.kt

owncloudApp/src/main/res/layout/create_shortcut_dialog.xml

owncloudApp/src/main/java/com/owncloud/android/ui/activity/FileDisplayActivity.kt

owncloudApp/src/main/java/com/owncloud/android/presentation/files/filelist/FileListAdapter.kt

owncloudApp/src/main/res/values/strings.xml

JuancaG05

Some more changes here @Aitorbp. Pay attention to the comments in previous CR, you skipped some of them

owncloudApp/src/main/java/com/owncloud/android/extensions/ActivityExt.kt

.../java/com/owncloud/android/presentation/files/createshortcut/CreateShortcutDialogFragment.kt

owncloudApp/src/main/java/com/owncloud/android/presentation/files/filelist/FileListAdapter.kt

owncloudApp/src/main/java/com/owncloud/android/ui/activity/FileDisplayActivity.kt

JuancaG05

LGTM now!

jesmrec · 2024-06-14T10:41:18Z

(1) [FIXED]

This is our current implementation together with iOS and web:

Android	iOS	Web

iOS and web put the URL field above, and the shortcut name below, just the opposite as we do. We should align behaviour across platforms.
iOS and web call the submit button as Create or Create shortcut, whereas we call it YES (i guess, this is an Android default). We should go for Create as well.
I'd remove the word new from the title. If you create something, this is always going to be new.

Pixel 2, Android11
87d3a1d2

jesmrec · 2024-06-14T10:46:04Z

(2) [IMPROVEMENT] [DONE]

As improvement, i'd be cool to have the file name like in web:

the .url at the end makes clear that the file name is the requested field, and the extension must not be typed by the user.

Pixel 2, Android11
87d3a1d2

jesmrec · 2024-06-14T11:20:57Z

(3) [FIXED]

Tiny detail for long names:

error message is: File name must not be longer than 223 characters

By typing exactly 223 characters, the message is there. It shouldn't or changing the value to 222

Pixel 2, Android11
87d3a1d2

jesmrec · 2024-06-14T11:39:59Z

(4) [FIXED]

About this comment:

I format it by default with http because if the websites do not support https, the websites will say: The site can't be reached. For example this one: http://www.edu4java.com/es/web/web30.html.
On the contrary, if we write a website with http, but it supports https, it will redirect us directly to https.

but, what happens if it supports http and not https? you'll get the error as well. You can check this with a basic oC10 server. The fact of supporting http, https or both is a matter of the hosting server, each one has its own setup and we can not assume an specific behaviour based in only one example.

Both web and iOS use https as default. I'd go for this.

Pixel 2, Android11
87d3a1d2

jesmrec · 2024-06-14T11:52:05Z

(5) [FIXED]

Create a shortcut and submit it

Current:

In the uploads view, the entry does not have a proper icon:

Expected:

Could be used the same icon as in the list of files?

Pixel 2, Android11
87d3a1d2

jesmrec · 2024-06-14T12:23:54Z

(6) [FIXED]

I'm not pretty sure to ellipsize the URL when it is very long. The URL to open is sensible information that is hidden to the user. Let me know if i'm wrong, but it is being ellipsized if the length is longer than 1 line. That means, almost every URL that points to a subfolder/subdomain is going to be ellipsized.

I'd remove that, or expand to a longer size

Pixel 2, Android11
87d3a1d2

Aitorbp · 2024-06-17T12:15:36Z

(6)

I'm not pretty sure to ellipsize the URL when it is very long. The URL to open is sensible information that is hidden to the user. Let me know if i'm wrong, but it is being ellipsized if the length is longer than 1 line. That means, almost every URL that points to a subfolder/subdomain is going to be ellipsized.

I'd remove that, or expand to a longer size

Pixel 2, Android11 87d3a1d2

Regarding the ellipsize of the URL when it is very long, the following occurs: if we want to put a maximum of three lines and set a truncated ellipsize in the middle, it will not work. Android does not have this functionality automatically, it would have to be programmed. Therefore the following options are considered:

Set the ellipsize at the end of the text, keeping a maximum of three lines.
Set the ellipsize in the middle with a maximum of three lines, making a method programmatically. A calculation would have to be made to put the ellipsize in the center of the second line. I don't know how this would work...
Set a HorizontalScrollLayout so that it scrolls if the text exceeds the maximum of one line. With this component it only detects one line, I understand that it could also be done programmatically so that it detects more lines.
The last option would be to leave it as iOS has it, without any type of restriction and that the URL occupies all it needs.

@jesmrec @JuancaG05

JuancaG05 · 2024-06-17T12:47:17Z

Set a HorizontalScrollLayout so that it scrolls if the text exceeds the maximum of one line. With this component it only detects one line, I understand that it could also be done programmatically so that it detects more lines.

I would discard this option directly. A scroll in a dialog is no good practice.

The last option would be to leave it as iOS has it, without any type of restriction and that the URL occupies all it needs.

This is not a good option for me. What if the URL is so so long (not strange case currently) that the dialog gets too big and we cannot see its buttons? We need to set a limit somewhere

Why is it that you can ellipsize at the end a text of more than 1 line but not in the middle?

jesmrec · 2024-06-17T12:54:23Z

This is not a good option for me. What if the URL is so so long (not strange case currently) that the dialog gets too big and we cannot see its buttons? We need to set a limit somewhere

Does not the dialog (including the buttons) expand? i mean, if the text is too long, the buttons are on the bottom in the same way, just the central is expanded.

JuancaG05 · 2024-06-18T06:17:34Z

Does not the dialog (including the buttons) expand? i mean, if the text is too long, the buttons are on the bottom in the same way, just the central is expanded.

Yes, the center will expand, but... what if it expands so much that the buttons get out of the screen?

Aitorbp · 2024-06-18T09:31:03Z

To sum up, to align with iOS behavior, we're going to leave the url unrestricted to the maximum number of lines, but add a scrollview so that when the text takes up more space than the screen, the url element will scroll.

Aitorbp · 2024-06-18T10:07:56Z

All reports are ready to be tested again @jesmrec

jesmrec · 2024-06-18T10:25:14Z

everything is fixed. Now, i will face a 2nd QA round.

jesmrec · 2024-06-18T12:47:15Z

(7) [FIXED]

Minor change

Typing a URL with blanks, the error The URL cannot contain spaces is displayed.

This is correct, but i'd use blanks instead of spaces, since "spaces" has a different meaning... it may lead to confusion

Aitorbp · 2024-06-18T13:00:19Z

Changed report (7), ready to test @jesmrec

jesmrec · 2024-06-19T13:02:39Z

Related owncloud/web#11063

I noticed that the shorcuts created in the web client (oCIS) are not open in mobile clients if they lack of protocol prefix. If i'm not wrong, the current approach in Android app is adding the default protocol prefix (https) when the shortcut is open (not in creation), right @Aitorbp ?

So, we have two options here:

Getting the current approach as correct for the moment and going ahead. If the prefix default protocol should be added in creation phase as before, it could be changed in a new PR
Wait till a solution across the clients is agreed in the web issue mentioned above.

which one do you like the most?

Aitorbp · 2024-06-19T13:27:33Z

Related owncloud/web#11063

I noticed that the shorcuts created in the web client (oCIS) are not open in mobile clients if they lack of protocol prefix. If i'm not wrong, the current approach in Android app is adding the default protocol prefix (https) when the shortcut is open (not in creation), right @Aitorbp ?

So, we have two options here:

Getting the current approach as correct for the moment and going ahead. If the prefix default protocol should be added in creation phase as before, it could be changed in a new PR

Wait till a solution across the clients is agreed in the web issue mentioned above.

which one do you like the most?

Right we add the default protocol prefix when the shortcut is open. In my opinion, I would go for the current approach, even if the web were to set the protocol, the application would not be affected.

jesmrec · 2024-06-19T14:50:07Z

owncloud/web#11063 (comment)

Aitorbp · 2024-06-20T07:31:19Z

Added back the protocol in shortcut creation.

…esButton func and changed naming isCreateShortcutButtonEnabled

…d style xml

…istFragment

… change extractUrlFromFile to the class and minor fixing

…dd .url text in the end of edittext

…_no_blanks name string

…ShortcutFileInBrowser

jesmrec · 2024-06-20T08:25:02Z

That's fixed, now adding the protocol in both creation and opening.

jesmrec · 2024-06-20T08:27:19Z

Approved, ready to go! 💯

Aitorbp self-assigned this Jun 10, 2024

Aitorbp linked an issue Jun 10, 2024 that may be closed by this pull request

[FEATURE REQUEST] Open and create .url shortcut files #4413

Closed

12 tasks

Aitorbp force-pushed the feature/open_create_url_shortcut_files branch 2 times, most recently from ba59abb to 3567b11 Compare June 11, 2024 07:35

JuancaG05 requested changes Jun 12, 2024

View reviewed changes

Aitorbp force-pushed the feature/open_create_url_shortcut_files branch from f80f80d to bcb571c Compare June 13, 2024 09:00

Aitorbp requested a review from JuancaG05 June 13, 2024 09:20

JuancaG05 requested changes Jun 13, 2024

View reviewed changes

JuancaG05 approved these changes Jun 13, 2024

View reviewed changes

Aitorbp force-pushed the feature/open_create_url_shortcut_files branch from f353ed7 to 3b28f67 Compare June 18, 2024 09:36

feat: added new string and created ShortcutDialogFragment

fa90f50

Aitorbp and others added 19 commits June 20, 2024 08:33

feat: added icon to resources and in item list and implemented in FAB

936bb55

feat: added release notes

69c1f3e

feat: prevent to open url files in PreviewTextFragment

9e594f4

feat: create, upload and open url functionality

a2b010c

refactor: changed naming and refactor

d5a7577

fix: removed doc in newInstance, button yes listener moved to enableY…

171b1b0

…esButton func and changed naming isCreateShortcutButtonEnabled

refactor: changed name variable, remove activity from method, improve…

1534a65

…d style xml

fix: release notes changes

1bf073b

chore: add calens

f7adef7

docs: calens changelog updated

4f3f59b

refactor: using MAX_FILENAME_LENGTH and forbiddenChars from MainFileL…

efaa56a

…istFragment

fix: improve ope Shortcut file dialog, fix algorithm enableYesButton,…

2944056

… change extractUrlFromFile to the class and minor fixing

fix: changed named Yes to Create, change position name and url, and a…

c382fb8

…dd .url text in the end of edittext

fix: default https format url and 223 file name length fixed

38e66d3

fix: added url icon to upload list

3607101

fix: added scrollview in open shortcut and added extensión url to name

a479bc9

fix: changed "spaces" to "blanks" in create_shortcut_dialog_url_error…

f90153d

…_no_blanks name string

fix: changed formatUrl func from CreateShortcutDialogFragment to open…

e6b9064

…ShortcutFileInBrowser

fix: Added again formatUrl func to CreateShortcutDialogFragment

d36ccf3

Aitorbp force-pushed the feature/open_create_url_shortcut_files branch from bcbaede to d36ccf3 Compare June 20, 2024 07:33

jesmrec added the Approved by qa label Jun 20, 2024

Aitorbp merged commit 4bffb3a into master Jun 20, 2024
5 checks passed

Aitorbp deleted the feature/open_create_url_shortcut_files branch June 20, 2024 08:29

Aitorbp mentioned this pull request Jun 21, 2024

[FEATURE REQUEST] Show same remove dialog for every kind of file or folder #4404

Merged

3 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[FEATURE REQUEST] Open and create .url shortcut files #4420

[FEATURE REQUEST] Open and create .url shortcut files #4420

Aitorbp commented Jun 10, 2024 •

edited by jesmrec

Loading

JuancaG05 left a comment

JuancaG05 left a comment

JuancaG05 left a comment

jesmrec commented Jun 14, 2024 •

edited

Loading

jesmrec commented Jun 14, 2024 •

edited

Loading

jesmrec commented Jun 14, 2024 •

edited

Loading

jesmrec commented Jun 14, 2024 •

edited

Loading

jesmrec commented Jun 14, 2024 •

edited

Loading

jesmrec commented Jun 14, 2024 •

edited

Loading

Aitorbp commented Jun 17, 2024 •

edited

Loading

(6)

JuancaG05 commented Jun 17, 2024

jesmrec commented Jun 17, 2024

JuancaG05 commented Jun 18, 2024

Aitorbp commented Jun 18, 2024

Aitorbp commented Jun 18, 2024

jesmrec commented Jun 18, 2024

jesmrec commented Jun 18, 2024 •

edited

Loading

Aitorbp commented Jun 18, 2024 •

edited

Loading

jesmrec commented Jun 19, 2024

Aitorbp commented Jun 19, 2024

jesmrec commented Jun 19, 2024

Aitorbp commented Jun 20, 2024

jesmrec commented Jun 20, 2024

jesmrec commented Jun 20, 2024

[FEATURE REQUEST] Open and create .url shortcut files #4420

[FEATURE REQUEST] Open and create .url shortcut files #4420

Conversation

Aitorbp commented Jun 10, 2024 • edited by jesmrec Loading

Related Issues

QA

JuancaG05 left a comment

Choose a reason for hiding this comment

JuancaG05 left a comment

Choose a reason for hiding this comment

JuancaG05 left a comment

Choose a reason for hiding this comment

jesmrec commented Jun 14, 2024 • edited Loading

(1) [FIXED]

jesmrec commented Jun 14, 2024 • edited Loading

(2) [IMPROVEMENT] [DONE]

jesmrec commented Jun 14, 2024 • edited Loading

(3) [FIXED]

jesmrec commented Jun 14, 2024 • edited Loading

(4) [FIXED]

jesmrec commented Jun 14, 2024 • edited Loading

(5) [FIXED]

jesmrec commented Jun 14, 2024 • edited Loading

(6) [FIXED]

Aitorbp commented Jun 17, 2024 • edited Loading

(6)

JuancaG05 commented Jun 17, 2024

jesmrec commented Jun 17, 2024

JuancaG05 commented Jun 18, 2024

Aitorbp commented Jun 18, 2024

Aitorbp commented Jun 18, 2024

jesmrec commented Jun 18, 2024

jesmrec commented Jun 18, 2024 • edited Loading

(7) [FIXED]

Aitorbp commented Jun 18, 2024 • edited Loading

jesmrec commented Jun 19, 2024

Aitorbp commented Jun 19, 2024

jesmrec commented Jun 19, 2024

Aitorbp commented Jun 20, 2024

jesmrec commented Jun 20, 2024

jesmrec commented Jun 20, 2024

Aitorbp commented Jun 10, 2024 •

edited by jesmrec

Loading

jesmrec commented Jun 14, 2024 •

edited

Loading

jesmrec commented Jun 14, 2024 •

edited

Loading

jesmrec commented Jun 14, 2024 •

edited

Loading

jesmrec commented Jun 14, 2024 •

edited

Loading

jesmrec commented Jun 14, 2024 •

edited

Loading

jesmrec commented Jun 14, 2024 •

edited

Loading

Aitorbp commented Jun 17, 2024 •

edited

Loading

jesmrec commented Jun 18, 2024 •

edited

Loading

Aitorbp commented Jun 18, 2024 •

edited

Loading