Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add workaround for composed types #12

Merged
merged 2 commits into from
Nov 26, 2021
Merged

add workaround for composed types #12

merged 2 commits into from
Nov 26, 2021

Conversation

micbar
Copy link
Contributor

@micbar micbar commented Nov 26, 2021

Description

There are bugs in the openapi Generator
OpenAPITools/openapi-generator#6378
OpenAPITools/openapi-generator#2892

Workaround

  • Dont use inline schemas, create a named schema for all props when working with allOf

@TheOneRing
Copy link
Member

Hm seems like it didn't help.

C:\CraftRoot\build\_\30b36579\libre-graph-api\out\qt\client [allof-workaround ≡ +1 ~0 -0 !]> cmake -GNinja .
-- The C compiler identification is MSVC 19.29.30136.0
-- The CXX compiler identification is MSVC 19.29.30136.0
-- Detecting C compiler ABI info
-- Detecting C compiler ABI info - done
-- Check for working C compiler: C:/Program Files/Microsoft Visual Studio/2022/Community/VC/Tools/MSVC/14.29.30133/bin/HostX64/x64/cl.exe - skipped
-- Detecting C compile features
-- Detecting C compile features - done
-- Detecting CXX compiler ABI info
-- Detecting CXX compiler ABI info - done
-- Check for working CXX compiler: C:/Program Files/Microsoft Visual Studio/2022/Community/VC/Tools/MSVC/14.29.30133/bin/HostX64/x64/cl.exe - skipped
-- Detecting CXX compile features
-- Detecting CXX compile features - done
-- Configuring done
-- Generating done
-- Build files have been written to: C:/CraftRoot/build/_/30b36579/libre-graph-api/out/qt/client
C:\CraftRoot\build\_\30b36579\libre-graph-api\out\qt\client [allof-workaround ≡ +1 ~0 -0 !]> ninja
[2/38] Building CXX object CMakeFiles\client.dir\OAIDriveInline.cpp.obj
FAILED: CMakeFiles/client.dir/OAIDriveInline.cpp.obj
C:\PROGRA~1\MICROS~3\2022\COMMUN~1\VC\Tools\MSVC\1429~1.301\bin\HostX64\x64\cl.exe  /nologo /TP -DQT_CORE_LIB -DQT_NETWORK_LIB -I. -Iclient_autogen\include -IC:\CraftRoot\include\qt5 -IC:\CraftRoot\include\qt5\QtCore -IC:\CraftRoot\.\mkspecs\win32-msvc -IC:\CraftRoot\include\qt5\QtNetwork /DWIN32 /D_WINDOWS /W3 /GR /EHsc /W4 /MDd /Zi /Ob0 /Od /RTC1 -std:c++14 /showIncludes /FoCMakeFiles\client.dir\OAIDriveInline.cpp.obj /FdCMakeFiles\client.dir\client.pdb /FS -c OAIDriveInline.cpp
cl : Command line warning D9025 : overriding '/W3' with '/W4'
C:\CraftRoot\build\_\30b36579\libre-graph-api\out\qt\client\OAIDrive.h(126): error C2065: 'OAIDriveItem': undeclared identifier

@refs
Copy link
Member

refs commented Nov 26, 2021

if it works with the cpp generator 👍 LGTM and can be merged

@micbar micbar merged commit f89d7a8 into main Nov 26, 2021
@delete-merged-branch delete-merged-branch bot deleted the allof-workaround branch November 26, 2021 14:20
micbar added a commit that referenced this pull request Nov 26, 2021
add workaround for composed types
@github-pages github-pages bot temporarily deployed to github-pages November 26, 2021 19:14 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants