Allow configuring storage registry with envvars #7554
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: jkoberg <jkoberg@owncloud.com>
mmattel
reviewed
Oct 20, 2023
Co-authored-by: Martin <github@diemattels.at>
|
Kudos, SonarCloud Quality Gate passed!
|
@dragotin once you are familiar with the new envvars, could you improve the description in a follow-up PR? |
mmattel
reviewed
Oct 20, 2023
| JSON string `yaml:"json"` // TODO: configure via env? | ||
| Driver string `yaml:"driver" env:"GATEWAY_STORAGE_REGISTRY_DRIVER" desc:"The driver name of the storage registry to use."` | ||
| Rules []string `yaml:"rules" env:"GATEWAY_STORAGE_REGISTRY_RULES" desc:"The rules for the storage registry."` | ||
| JSON string `yaml:"json" env:"GATEWAY_STORAGE_REGISTRY_CONFIG_JSON" desc:"Additional configuration for the storage registry in json format."` |
There was a problem hiding this comment.
Q: how does the json get assigned to the variable? Imho a reference to a file would do this.
See: USERS_LDAP_CACERT where we have a default path/file if not otherwise defined: If not defined, the root directory derives from $OCIS_BASE_DATA_PATH:/idm. Just my 2c.
ownclouders
pushed a commit
that referenced
this pull request
Oct 20, 2023
Allow configuring storage registry with envvars
12 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows configuring the storage registry in the gateway service using envvars