[tests-only][full-ci] tests: add api tests for changing system language using graph api #7817
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SwikritiT
force-pushed
the
tests/language-change-with-grap-api
branch
from
05c7b6a
to
c3bdd1a
Compare
SwikritiT
commented
Nov 28, 2023
SwikritiT
commented
Nov 28, 2023
Comment on lines
+266
to
+270
| | language | subject | message | api | | ||
| | de | Neue Freigabe | Alice Hansen hat textfile1.txt mit Ihnen geteilt | Graph | | ||
| | de | Neue Freigabe | Alice Hansen hat textfile1.txt mit Ihnen geteilt | settings | | ||
| | es | Recurso compartido | Alice Hansen compartió textfile1.txt contigo | Graph | | ||
| | es | Recurso compartido | Alice Hansen compartió textfile1.txt contigo | settings | |
There was a problem hiding this comment.
@ScharfViktor I've refactored this like so ^ to include a few scenarios with settings API, if we don't need coverage for settings API I can remove the related code.
There was a problem hiding this comment.
fine, thanks. Since we have settings endpoint it's good to have a couple of tests for it
SwikritiT
requested review from
SagarGi,
saw-jan,
amrita-shrestha,
PrajwolAmatya,
nirajacharya2 and
ScharfViktor
SwikritiT
commented
Nov 28, 2023
SwikritiT
force-pushed
the
tests/language-change-with-grap-api
branch
from
c3bdd1a
to
40b185e
Compare
ScharfViktor
approved these changes
Nov 28, 2023
Comment on lines
+266
to
+270
| | language | subject | message | api | | ||
| | de | Neue Freigabe | Alice Hansen hat textfile1.txt mit Ihnen geteilt | Graph | | ||
| | de | Neue Freigabe | Alice Hansen hat textfile1.txt mit Ihnen geteilt | settings | | ||
| | es | Recurso compartido | Alice Hansen compartió textfile1.txt contigo | Graph | | ||
| | es | Recurso compartido | Alice Hansen compartió textfile1.txt contigo | settings | |
There was a problem hiding this comment.
fine, thanks. Since we have settings endpoint it's good to have a couple of tests for it
SwikritiT
force-pushed
the
tests/language-change-with-grap-api
branch
from
40b185e
to
01f78ce
Compare
saw-jan
approved these changes
Nov 28, 2023
|
Kudos, SonarCloud Quality Gate passed!
|
delete-merged-branch
bot
deleted the
tests/language-change-with-grap-api
branch
2403905
pushed a commit
to 2403905/ocis
that referenced
this pull request
Dec 4, 2023
2403905
pushed a commit
to 2403905/ocis
that referenced
this pull request
Dec 8, 2023
2403905
pushed a commit
to 2403905/ocis
that referenced
this pull request
Jan 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue
Fixes: #7764