apiTest: listPermissions #7946
Merged
apiTest: listPermissions #7946
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ScharfViktor
requested review from
wkloucek,
micbar,
phil-davis and
individual-it
as code owners
|
Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes. |
|
@individual-it @saw-jan I created first test as example. ready to discuss suggestions and get feedback. |
saw-jan
reviewed
Dec 13, 2023
saw-jan
reviewed
Dec 13, 2023
saw-jan
reviewed
Dec 13, 2023
saw-jan
reviewed
Dec 13, 2023
saw-jan
reviewed
Dec 13, 2023
saw-jan
reviewed
Dec 13, 2023
|
Comment on lines
+106
to
+109
| public static function getBetaFullUrl(string $baseUrl, string $path): string { | ||
| $baseUrl = rtrim($baseUrl, "/"); | ||
| return $baseUrl . '/graph/v1beta1/' . $path; | ||
| } |
There was a problem hiding this comment.
what will we do when the path changes? change every occurrence of getBetaFullUrl to getFullUrl?
ownclouders
pushed a commit
that referenced
this pull request
Dec 13, 2023
* apiTest: listPermissions * fix after review * fix
2403905
pushed a commit
to 2403905/ocis
that referenced
this pull request
Jan 24, 2024
* apiTest: listPermissions * fix after review * fix
18 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
first api test for new sharing ng api:
getting permissions list: https://owncloud.dev/libre-graph-api/#/drives.permissions/ListPermissions