Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove accessDeniedHelperUrl from config #7970

Merged
merged 4 commits into from
Dec 14, 2023

Conversation

AlexAndBear
Copy link
Contributor

Description

Change: Remove accessDeniedHelpUrl from the config

We've removed the option accessDeniedHelpUrl from the config, since other clients weren't able to consume it.
In order to be accessible by other clients, not just Web, it should be configured via the theme.json file.

Related Issue

  • Fixes <issue_link>

Motivation and Context

How Has This Been Tested?

  • test environment:
  • test case 1:
  • test case 2:
  • ...

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

@AlexAndBear AlexAndBear enabled auto-merge (squash) December 14, 2023 09:07
Copy link

sonarcloud bot commented Dec 14, 2023

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@AlexAndBear AlexAndBear merged commit 7345c7d into master Dec 14, 2023
4 checks passed
@delete-merged-branch delete-merged-branch bot deleted the remove-access-denied-help-url-from-config branch December 14, 2023 09:44
ownclouders pushed a commit that referenced this pull request Dec 14, 2023
* Remove accessDeniedHelperUrl from config

* Enhance changelog item

* Adjust former changelog item

* Force rename
@micbar micbar mentioned this pull request Dec 20, 2023
71 tasks
2403905 pushed a commit to 2403905/ocis that referenced this pull request Jan 24, 2024
* Remove accessDeniedHelperUrl from config

* Enhance changelog item

* Adjust former changelog item

* Force rename
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants