Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[tests-only]test: add test for shared with me #8010

Merged
merged 6 commits into from
Jan 25, 2024
Merged

[tests-only]test: add test for shared with me #8010

merged 6 commits into from
Jan 25, 2024

Conversation

SwikritiT
Copy link
Contributor

@SwikritiT SwikritiT commented Dec 19, 2023 •
edited
Loading

Description

Scenarios added :

  • Scenario: user lists the file shared with them
  • Scenario: user lists the folder shared with them

Related Issue

Motivation and Context

How Has This Been Tested?

  • locally
  • CI

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

@SwikritiT SwikritiT self-assigned this Dec 19, 2023
@SwikritiT SwikritiT force-pushed the tests/add-tests-shared-with-mw branch 2 times, most recently from 986ffab to 3027fee Compare December 20, 2023 04:49
@SwikritiT SwikritiT marked this pull request as ready for review December 20, 2023 05:01
@SwikritiT SwikritiT force-pushed the tests/add-tests-shared-with-mw branch from 3027fee to 342fc13 Compare December 20, 2023 10:19
@ScharfViktor ScharfViktor mentioned this pull request Dec 20, 2023
Merged
9 tasks
@SwikritiT SwikritiT force-pushed the tests/add-tests-shared-with-mw branch from 342fc13 to 0caec98 Compare December 20, 2023 11:22
@SwikritiT SwikritiT force-pushed the tests/add-tests-shared-with-mw branch from 0caec98 to deedbdd Compare December 27, 2023 06:17
@PrajwolAmatya PrajwolAmatya mentioned this pull request Dec 27, 2023
Closed
9 tasks
@SwikritiT SwikritiT force-pushed the tests/add-tests-shared-with-mw branch from deedbdd to a101ece Compare December 28, 2023 04:50
@SwikritiT SwikritiT force-pushed the tests/add-tests-shared-with-mw branch 2 times, most recently from d451add to 0e4b53b Compare December 28, 2023 05:35
grgprarup
grgprarup previously approved these changes Dec 28, 2023
View reviewed changes
Copy link
Contributor

@grgprarup grgprarup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@SwikritiT

This comment was marked as outdated.

Sign in to view
@SwikritiT SwikritiT removed their assignment Jan 12, 2024
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Jan 24, 2024

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@saw-jan saw-jan merged commit 0071748 into master Jan 25, 2024
4 checks passed
@delete-merged-branch delete-merged-branch bot deleted the tests/add-tests-shared-with-mw branch January 25, 2024 04:03
ownclouders pushed a commit that referenced this pull request Jan 25, 2024
@SwikritiT
[tests-only]test: add test for shared with me (#8010)
4540ea1 
* test: add test for shared with me

* test: add test for shared with me shared file

* add missing field and add test to expected to fail

* address review

* test: move file

* tests: make differente funtion for regex fileid pattern matching
@nirajacharya2 nirajacharya2 mentioned this pull request Jan 25, 2024
Closed
17 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ScharfViktor ScharfViktor ScharfViktor approved these changes

@SagarGi SagarGi Awaiting requested review from SagarGi

@nabim777 nabim777 Awaiting requested review from nabim777

@amrita-shrestha amrita-shrestha Awaiting requested review from amrita-shrestha

@nirajacharya2 nirajacharya2 Awaiting requested review from nirajacharya2

@saw-jan saw-jan Awaiting requested review from saw-jan

@grgprarup grgprarup Awaiting requested review from grgprarup

Assignees

@nirajacharya2 nirajacharya2

Labels
QA:team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@SwikritiT @grgprarup @SagarGi @saw-jan @ScharfViktor @nirajacharya2