Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[tests-only] adding test for sharedWithMe end point for resource in project space and personal space #8292

Merged
merged 1 commit into from
Mar 1, 2024
Merged

[tests-only] adding test for sharedWithMe end point for resource in project space and personal space #8292

merged 1 commit into from
Mar 1, 2024

Conversation

nirajacharya2
Copy link
Contributor

@nirajacharya2 nirajacharya2 commented Jan 26, 2024 •
edited
Loading

Description

Scenarios added :

Scenario: user lists the file shared with them from project space
Scenario: user lists the folder shared with them from project space
Scenario: user lists the folder shared with them from project space after the sharer is disabled
Scenario: user lists the folder shared with them from project space after the sharer is deleted
Scenario: user lists the file shared with them from personal space after the sharer is deleted

Related Issue

Motivation and Context

How Has This Been Tested?

  • locally
  • CI

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

@nirajacharya2 nirajacharya2 self-assigned this Jan 26, 2024
@nirajacharya2 nirajacharya2 mentioned this pull request Jan 29, 2024
Closed
17 tasks
@nirajacharya2 nirajacharya2 force-pushed the test-share-with-me-space branch 2 times, most recently from f877061 to 80af4fb Compare January 30, 2024 05:02
@nirajacharya2 nirajacharya2 marked this pull request as ready for review January 30, 2024 05:40
@nirajacharya2 nirajacharya2 force-pushed the test-share-with-me-space branch 2 times, most recently from 16d96e9 to 84f35e1 Compare January 31, 2024 08:27
@saw-jan
Copy link
Member

saw-jan commented Jan 31, 2024 •
edited
Loading

waiting for PR #8322, blocked until then

@nirajacharya2 nirajacharya2 changed the title [tests-only][full-ci]adding test for sharedWithMe end point for resource in project space [tests-only] adding test for sharedWithMe end point for resource in project space Feb 2, 2024
@saw-jan
Copy link
Member

saw-jan commented Feb 2, 2024

@nirajacharya2 Please, update the PR. the fix PR has been merged

@nirajacharya2 nirajacharya2 force-pushed the test-share-with-me-space branch 3 times, most recently from f71cfb8 to 4e43e0b Compare February 2, 2024 11:19
saw-jan
saw-jan reviewed Feb 2, 2024
View reviewed changes
tests/acceptance/features/apiSharingNg/sharedWithMe.feature Outdated
Comment on lines 1398 to 4214
And the administrator has deleted user "Alice" using the provisioning API
When user "Brian" lists the shares shared with him using the Graph API
Then the HTTP status code should be "200"
"""
{
"type": "object",
"required": [
"value"
],
"properties": {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we have the share even the sharer is deleted?

CC @SagarGi

Copy link
Member

@SagarGi SagarGi Feb 2, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With the sharer deleted his/her resource is deleted AFAIK. And i think we should not have any shared responses. @ScharfViktor might have some details regarding it. i have created an issue for it which might be related to it. lets wait if its the actual bug> #8356

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we have the share even the sharer is deleted?

CC @SagarGi

yes, but for project space only. In personal space the share is deleted. We have different behaviour in project space and personal space. my assumption is that in project spaces the owner is set to a special user of the CS3 #8314 (comment) so deleting the user dose not delete the share. need clarification
CC @ScharfViktor

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see that it's correct behavior
personal space: sharer is deleted - no share anymore
project space: sharer is deleted - share is exist. Another user manager can manage this share

@nirajacharya2 nirajacharya2 force-pushed the test-share-with-me-space branch 2 times, most recently from 5ab1d03 to 3687e59 Compare February 28, 2024 06:57
@nirajacharya2 nirajacharya2 force-pushed the test-share-with-me-space branch 2 times, most recently from 319263a to 475282c Compare February 29, 2024 02:53
grgprarup
grgprarup approved these changes Mar 1, 2024
View reviewed changes
Copy link
Contributor

@grgprarup grgprarup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Mar 1, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

saw-jan
saw-jan reviewed Mar 1, 2024
View reviewed changes
tests/acceptance/features/apiSharingNg/sharedWithMe.feature
"""


Scenario: user lists the file shared with them from personal space after the sharer is deleted
Copy link
Member

@saw-jan saw-jan Mar 1, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please, add scenarios per item from #7826 and the PR title would be meaningful.
Also, it will be easier to manage the PRs and scenarios

@nirajacharya2 nirajacharya2 changed the title [tests-only] adding test for sharedWithMe end point for resource in project space [tests-only] adding test for sharedWithMe end point for resource in project space and personal space Mar 1, 2024
@saw-jan saw-jan merged commit fb1d933 into master Mar 1, 2024
2 checks passed
@delete-merged-branch delete-merged-branch bot deleted the test-share-with-me-space branch March 1, 2024 09:52
ownclouders pushed a commit that referenced this pull request Mar 1, 2024
@nirajacharya2
adding test for sharedWithMe endpoint for resource in project space (#…
c62ec0e 
…8292)
rhafer pushed a commit to rhafer/ocis that referenced this pull request Mar 12, 2024
@nirajacharya2 @rhafer
adding test for sharedWithMe endpoint for resource in project space (o…
021afbf 
…wncloud#8292)

(cherry picked from commit fb1d933)
@rhafer rhafer mentioned this pull request Mar 12, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ScharfViktor ScharfViktor ScharfViktor left review comments

@grgprarup grgprarup grgprarup approved these changes

@saw-jan saw-jan saw-jan approved these changes

@SagarGi SagarGi Awaiting requested review from SagarGi

@amrita-shrestha amrita-shrestha Awaiting requested review from amrita-shrestha

@PrajwolAmatya PrajwolAmatya Awaiting requested review from PrajwolAmatya

@S-Panta S-Panta Awaiting requested review from S-Panta

@nabim777 nabim777 Awaiting requested review from nabim777

Assignees

@nirajacharya2 nirajacharya2

Labels
QA:team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@nirajacharya2 @saw-jan @grgprarup @SagarGi @amrita-shrestha @nabim777 @S-Panta @PrajwolAmatya @ScharfViktor