Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[tests-only] [full-ci] adding tests for shareWithMe endpoint when resource is shared with a group #8388

Merged
merged 1 commit into from
Feb 15, 2024
Merged

[tests-only] [full-ci] adding tests for shareWithMe endpoint when resource is shared with a group #8388

merged 1 commit into from
Feb 15, 2024

Conversation

nirajacharya2
Copy link
Contributor

Description

Scenarios added :

Scenario: user lists a file shared with them in a group from personal space
Scenario: user lists the file shared with them in a group from project space
Scenario: user lists a folder shared with them in a group from personal space
Scenario: user lists the folder shared with them in a group from project space

Related Issue

Motivation and Context

How Has This Been Tested?

  • locally
  • CI

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

@nirajacharya2 nirajacharya2 self-assigned this Feb 7, 2024
@nirajacharya2 nirajacharya2 mentioned this pull request Feb 7, 2024
Closed
17 tasks
@nirajacharya2 nirajacharya2 force-pushed the test-share-with-me-shared-to-group branch 2 times, most recently from 87221b4 to 2860441 Compare February 8, 2024 08:58
@nirajacharya2 nirajacharya2 marked this pull request as ready for review February 8, 2024 08:58
@nirajacharya2 nirajacharya2 force-pushed the test-share-with-me-shared-to-group branch from 2860441 to 250e314 Compare February 13, 2024 06:21
@nirajacharya2 nirajacharya2 force-pushed the test-share-with-me-shared-to-group branch from 250e314 to f66b79f Compare February 13, 2024 11:24
@nirajacharya2 nirajacharya2 force-pushed the test-share-with-me-shared-to-group branch from f66b79f to 00ccbb8 Compare February 13, 2024 11:28
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Feb 13, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

saw-jan
saw-jan approved these changes Feb 13, 2024
View reviewed changes
Copy link
Member

@saw-jan saw-jan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

amrita-shrestha
amrita-shrestha approved these changes Feb 15, 2024
View reviewed changes
Copy link
Contributor

@amrita-shrestha amrita-shrestha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@saw-jan saw-jan merged commit faa8bdb into master Feb 15, 2024
3 checks passed
@delete-merged-branch delete-merged-branch bot deleted the test-share-with-me-shared-to-group branch February 15, 2024 06:25
ownclouders pushed a commit that referenced this pull request Feb 15, 2024
@nirajacharya2
adding tests for shareWithMe endpoint when resource is shared with a …
a01920a 
…group (#8388)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@saw-jan saw-jan saw-jan approved these changes

@amrita-shrestha amrita-shrestha amrita-shrestha approved these changes

@grgprarup grgprarup Awaiting requested review from grgprarup

@SagarGi SagarGi Awaiting requested review from SagarGi

@nabim777 nabim777 Awaiting requested review from nabim777

@S-Panta S-Panta Awaiting requested review from S-Panta

@PrajwolAmatya PrajwolAmatya Awaiting requested review from PrajwolAmatya

Assignees

@nirajacharya2 nirajacharya2

Labels
QA:team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nirajacharya2 @saw-jan @amrita-shrestha