fix the bug when the expiration dates can't be removed from link perm… #8413
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
micbar
reviewed
Feb 9, 2024
| @@ -202,7 +202,7 @@ func (g Graph) libreGraphPermissionFromCS3PublicShare(createdLink *link.PublicSh | |||
| } | |||
|
|
|||
| func parseAndFillUpTime(t *time.Time) *types.Timestamp { | |||
There was a problem hiding this comment.
@micbar So we want to limit the granularity of share expiration to a day? Didn't know that. Shouldn't that be done in the CS3 shareprovider then?
There was a problem hiding this comment.
@micbar needs discussion, the isZero check is valid and needed... but the rounding seems to be something we should talk about, the api allows setting not just the day but instead also allows to define the exact time ... so no rounding is needed, but we could be wrong, you have some minutes to talk about it?
rhafer
approved these changes
Feb 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…issions
Description
Related Issue
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist: