Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[full-ci] [tests-only] Added tests to list sharedWithMe for file with same name shared by multiple users #8448

Merged
merged 3 commits into from
Feb 20, 2024
Merged

[full-ci] [tests-only] Added tests to list sharedWithMe for file with same name shared by multiple users #8448

merged 3 commits into from
Feb 20, 2024

Conversation

grgprarup
Copy link
Contributor

Description

Added scenario:

  • Scenario: user lists the file with same name shared by two users with him/her
  • Scenario: user lists the folder with same name shared by two users with him/her

Related Issue

How Has This Been Tested?

  • Locally
  • 🤖

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

@grgprarup grgprarup self-assigned this Feb 14, 2024
@grgprarup grgprarup mentioned this pull request Feb 14, 2024
Closed
17 tasks
@grgprarup grgprarup force-pushed the sharing-resources-with-same-name branch from 5d5661d to 33db117 Compare February 14, 2024 09:48
amrita-shrestha
amrita-shrestha approved these changes Feb 15, 2024
View reviewed changes
Copy link
Contributor

@amrita-shrestha amrita-shrestha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

SagarGi
SagarGi reviewed Feb 15, 2024
View reviewed changes
Copy link
Member

@SagarGi SagarGi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

saw-jan
saw-jan requested changes Feb 15, 2024
View reviewed changes
Copy link
Member

@saw-jan saw-jan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's use minItems and maxItems to make more stricter checks

@grgprarup grgprarup force-pushed the sharing-resources-with-same-name branch from 33db117 to d02f182 Compare February 20, 2024 07:05
@grgprarup grgprarup force-pushed the sharing-resources-with-same-name branch from d02f182 to 80c980f Compare February 20, 2024 07:06
saw-jan
saw-jan approved these changes Feb 20, 2024
View reviewed changes
Copy link
Member

@saw-jan saw-jan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looking good ✨

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Feb 20, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@grgprarup grgprarup merged commit 288136f into master Feb 20, 2024
4 checks passed
@delete-merged-branch delete-merged-branch bot deleted the sharing-resources-with-same-name branch February 20, 2024 08:15
ownclouders pushed a commit that referenced this pull request Feb 20, 2024
@grgprarup
Merge pull request #8448 from owncloud/sharing-resources-with-same-name
f513263 
[full-ci] [tests-only] Added tests to list sharedWithMe for file with same name shared by multiple users
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SagarGi SagarGi SagarGi left review comments

@saw-jan saw-jan saw-jan approved these changes

@amrita-shrestha amrita-shrestha amrita-shrestha approved these changes

@nabim777 nabim777 nabim777 approved these changes

@S-Panta S-Panta Awaiting requested review from S-Panta

@PrajwolAmatya PrajwolAmatya Awaiting requested review from PrajwolAmatya

@nirajacharya2 nirajacharya2 Awaiting requested review from nirajacharya2

Assignees

@grgprarup grgprarup

Labels
QA:team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@grgprarup @SagarGi @saw-jan @amrita-shrestha @nabim777