Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: adjust sharing ng role names and descriptions #8743

Merged
merged 3 commits into from
Mar 27, 2024
Merged

refactor: adjust sharing ng role names and descriptions #8743

merged 3 commits into from
Mar 27, 2024

Conversation

JammingBen
Copy link
Contributor

Description

Adjusts display names and descriptions of sharing NG roles to align with the previously agreed upon terms.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

@JammingBen JammingBen self-assigned this Mar 27, 2024
@JammingBen
refactor: adjust sharing ng role names and descriptions
2968570 
Adjusts display names and descriptions of sharing NG roles to align with the previously agreed upon terms.
@JammingBen
Copy link
Contributor Author

SonarCloud complains about things that I either didn't touch or are nonsense IMO 🤷

@JammingBen JammingBen marked this pull request as ready for review March 27, 2024 10:36
fschade
fschade approved these changes Mar 27, 2024
View reviewed changes
Copy link
Contributor

@fschade fschade left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one little comment,
... if thats not a problem in your opinion, GO 🚀

@fschade
Copy link
Contributor

fschade commented Mar 27, 2024 •
edited
Loading

SonarCloud complains about things that I either didn't touch or are nonsense IMO 🤷

its ok, SC asks to use ResourcePermissions getters instead of directly accessing the properties, i took care, lets see

@rhafer
Copy link
Contributor

rhafer commented Mar 27, 2024

SonarCloud complains about things that I either didn't touch or are nonsense IMO 🤷

its ok, SC asks to use ResourcePermissions getters instead of directly accessing the properties, i took care, lets see

Pardon my french, but SC is just being stupid here. Using Getters() for boolean 🤦‍♂️

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Mar 27, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
1 New Bugs (required ≤ 0)

See analysis details on SonarCloud

Catch issues before they fail your Quality Gate with our IDE extension SonarLint

@JammingBen JammingBen merged commit 035b34d into master Mar 27, 2024
3 of 4 checks passed
@delete-merged-branch delete-merged-branch bot deleted the adjust-sharing-ng-role-names branch March 27, 2024 17:09
ownclouders pushed a commit that referenced this pull request Mar 27, 2024
@JammingBen
Merge pull request #8743 from owncloud/adjust-sharing-ng-role-names
3a5754a 
refactor: adjust sharing ng role names and descriptions
@micbar micbar mentioned this pull request Jun 19, 2024
Closed
24 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fschade fschade fschade approved these changes

@rhafer rhafer Awaiting requested review from rhafer

@tbsbdr tbsbdr Awaiting requested review from tbsbdr

Assignees

@JammingBen JammingBen

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@JammingBen @fschade @rhafer