Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[tests-only][full-ci]Add tests for listing drive root permission #8824

Merged
merged 1 commit into from
Apr 18, 2024

Conversation

amrita-shrestha
Copy link
Contributor

@amrita-shrestha amrita-shrestha commented Apr 10, 2024

Description

This PR has added tests for listing permission using /drives/{driveID}/root/permissions api endpoint.

Related Issue

Motivation and Context

How Has This Been Tested?

  • locally

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

@amrita-shrestha amrita-shrestha force-pushed the add-tests-for-list-permission-for-drives branch from f1deeba to 6de8520 Compare April 15, 2024 05:11
Copy link
Member

@SagarGi SagarGi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@amrita-shrestha amrita-shrestha force-pushed the add-tests-for-list-permission-for-drives branch from 6de8520 to 4a58fcf Compare April 17, 2024 09:08
@amrita-shrestha amrita-shrestha force-pushed the add-tests-for-list-permission-for-drives branch 2 times, most recently from 0b2abc1 to d945c32 Compare April 18, 2024 03:31
@amrita-shrestha amrita-shrestha force-pushed the add-tests-for-list-permission-for-drives branch from d945c32 to 71c6276 Compare April 18, 2024 08:52
Copy link
Member

@saw-jan saw-jan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link

sonarcloud bot commented Apr 18, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@saw-jan saw-jan merged commit da656cb into master Apr 18, 2024
4 checks passed
@delete-merged-branch delete-merged-branch bot deleted the add-tests-for-list-permission-for-drives branch April 18, 2024 09:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants