Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[full-ci] enhancement: handle ocm event notifications #9966

Merged
merged 5 commits into from
Sep 5, 2024

Conversation

fschade
Copy link
Contributor

@fschade fschade commented Sep 2, 2024

Description

By now, the sciencemesh part in reva was responsible to notify the invitee that a invitaion happened, in ocis we have a event driven approach.

This PR introduces that and handles those invitation events in the notification service by sending mails.

Related Issue

How Has This Been Tested?

  • not at all right now, next step

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

Copy link

update-docs bot commented Sep 2, 2024

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

@fschade
Copy link
Contributor Author

fschade commented Sep 2, 2024

@micbar what about our other services (activitylog, audit, ...), should i add the new event there too?

@micbar
Copy link
Contributor

micbar commented Sep 2, 2024

@micbar what about our other services (activitylog, audit, ...), should i add the new event there too?

Yes, that would be awesome!

@fschade fschade force-pushed the handle-ocm-invitation-event branch 2 times, most recently from 4213981 to bd6b6da Compare September 3, 2024 16:24
@fschade fschade marked this pull request as ready for review September 4, 2024 13:26
@mmattel
Copy link
Contributor

mmattel commented Sep 4, 2024

@fschade Pls check if the audit services also contains translation relevant end user strings (not log stuff). In case, you need to have a look at https://owncloud.dev/services/general-info/add-translations/ for a how to. This includes the translation setup and the readme addition.

Pls also have a look at the admin docs Email Notification Templates respectively in the corresponding notification readme if we are missing anything regarding email templating

@fschade fschade changed the title enhancement: handle ocm event notifications [full-ci] enhancement: handle ocm event notifications Sep 5, 2024
Copy link

sonarcloud bot commented Sep 5, 2024

Copy link
Contributor

@micbar micbar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm!

@butonic butonic merged commit 07e675e into owncloud:master Sep 5, 2024
4 checks passed
ownclouders pushed a commit that referenced this pull request Sep 5, 2024
[full-ci] enhancement: handle ocm event notifications
@butonic butonic deleted the handle-ocm-invitation-event branch September 6, 2024 06:55
@micbar micbar mentioned this pull request Sep 12, 2024
18 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

OCM. generation invitation doesn't send email
4 participants