Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: visiting public links with expired access token #11086

Merged
merged 1 commit into from
Jun 28, 2024

Conversation

JammingBen
Copy link
Collaborator

Description

Fixes bug where opening public links with an expired token would falsely show the access denied page. Instead, Web now tries to login the user. If that doesn't work, the user gets logged out.

Related Issue

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests
  • Documentation
  • Maintenance (e.g. dependency updates or tooling)

@JammingBen JammingBen self-assigned this Jun 24, 2024
@JammingBen JammingBen force-pushed the fix/public-link-token-expiry branch from 62635d4 to 3ddc3bd Compare June 24, 2024 09:59
Copy link

sonarcloud bot commented Jun 24, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
0.0% Condition Coverage on New Code (required ≥ 50%)

See analysis details on SonarCloud

@kulmann kulmann merged commit 41d5561 into stable-8.0 Jun 28, 2024
2 of 3 checks passed
@ScharfViktor ScharfViktor mentioned this pull request Jul 9, 2024
26 tasks
@kulmann kulmann deleted the fix/public-link-token-expiry branch September 5, 2024 19:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants