Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: upload overlay breaking with nested folders #11303

Merged
merged 1 commit into from
Aug 2, 2024

Conversation

JammingBen
Copy link
Collaborator

@JammingBen JammingBen commented Jul 30, 2024

Description

Fixes an issue where the upload overlay breaks when uploading a folder that contains exactly one folder (which then contains some files).

The top level folder did not have an upload id in such case, hence the overlay could not retrieve the correct information.

Related Issue

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests
  • Documentation
  • Maintenance (e.g. dependency updates or tooling)

@JammingBen JammingBen self-assigned this Jul 30, 2024
Fixes an issue where the upload overlay breaks when uploading a folder that contains exactly one folder (which then contains some files).

The top level folder did not have an upload id in such case, hence the overlay could not retrieve the correct information.
@JammingBen JammingBen force-pushed the fix/uploading-nested-folders branch from f45f3c1 to dd5b4c5 Compare July 30, 2024 12:52
Copy link

sonarcloud bot commented Jul 30, 2024

@JammingBen JammingBen merged commit f62af7e into stable-8.0 Aug 2, 2024
3 checks passed
@micbar micbar mentioned this pull request Sep 2, 2024
16 tasks
@kulmann kulmann deleted the fix/uploading-nested-folders branch September 5, 2024 19:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants