Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: sse notifications not working #9753

Merged
merged 1 commit into from
Oct 4, 2023
Merged

fix: sse notifications not working #9753

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions changelog/unreleased/enhancement-sse-get-notifications-instantly
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,5 +6,6 @@ every few seconds.

https://github.com/owncloud/web/pull/9451
https://github.com/owncloud/web/pull/9654
https://github.com/owncloud/web/pull/9753
https://github.com/owncloud/web/issues/9434
https://github.com/owncloud/web/issues/9635
7 changes: 6 additions & 1 deletion packages/web-runtime/src/components/Topbar/Notifications.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -139,7 +139,12 @@ export default {
console.error(`SSE notifications error: ${msg.data}`)
return
}
const data = JSON.parse(msg.data)
const parsedData = JSON.parse(msg.data) as { type: string; data?: Notification }
if (!parsedData?.data) {
return
}

const { data } = parsedData
if (data.notification_id) {
notifications.value = [data, ...unref(notifications)]
}
Expand Down