Add dropdowns to router route form for destinations and targets #2448
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
| name="destination.value" | ||
| label="Destination value" | ||
| control={control} | ||
| placeholder="Enter a destination value" |
There was a problem hiding this comment.
I do like matching the API shape roughly, but maybe we can tweak some words to make this a little more human-feeling. Maybe it's enough to just change the placeholder based on the type selected, or maybe we want to go as far as changing the label? It would also be nice to get some kind of guidance about the right format for an IP network. I assume it's some kind of block, maybe we can give an example.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR converts the text fields in the VPC Router Routes form to be — when appropriate — prepopulated dropdowns.
For Destinations, that's when the Destination Type has been selected as
Subnet; for Targets,Instances.Closes #2388