Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SoftNpu early return on empty guest virtio buffers, bump dlpi crate, fix duplicate crate import issue #274

Merged
merged 2 commits into from
Dec 14, 2022

Conversation

rcgoodfellow
Copy link
Contributor

SoftNpu early return on empty buffers

Break out of the guest packet processing loop early when there are no bytes to read. This has a non-trivial impact on latency reduction.

Bump dlpi

Bump the dlpi dependency. The latest version is less chatty with logging and the bug previously referenced is no longer an issue since we are not using the async API exported by the dlpi create.

Fix import issue

Set publish = false on the header check libraries. When importing propolis libraries, because both viona-api and bhyve-api have a sub-crate called header-check, cargo starts screaming. This is working around this issue with this fix

Other

The changes in propolis-standalone are in response to clippy complaints.

Break out of the guest packet processing loop early when there are no
bytes to read. This has a non-trivial impact on latency reduction.

Bump the dlpi dependency. The latest version is less chatty with logging
and the bug previously referenced is no longer an issue since we are not
using the async API exported by the dlpi create.

Set publish = false on the header check libraries. When importing
propolis libraries, because both viona-api and bhyve-api have a
sub-crate called header-check, cargo starts screaming.
@@ -4,6 +4,7 @@ version = "0.0.0"
authors = ["Patrick Mooney <pmooney@oxide.computer>"]
license = "MPL-2.0"
build = "build.rs"
publish = false
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh nice. I didn't know about that

@rcgoodfellow rcgoodfellow merged commit 5d948bf into master Dec 14, 2022
@rcgoodfellow rcgoodfellow deleted the ry-updates branch December 14, 2022 20:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants