Improve Kerberos auth test stability #127
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove keytabs created in test-resources, the test now copies them to the target/test-classes/kerberos dir
|
@ozangunalp lgtm. thank you for the investigation and producing the fix. |
k-wall
reviewed
Dec 15, 2023
| @@ -36,15 +35,15 @@ public void createTestPrincipals() { | |||
| "addprinc -randkey client/localhost@EXAMPLE.COM"); | |||
| lsResult = execInContainer("kadmin.local", "-q", | |||
| "ktadd -norandkey -k /client.keytab client/localhost@EXAMPLE.COM"); | |||
| copyFileFromContainer("/kafkabroker.keytab", "src/test/resources/kerberos/kafkabroker.keytab"); | |||
| copyFileFromContainer("/client.keytab", "src/test/resources/kerberos/client.keytab"); | |||
| copyFileFromContainer("/kafkabroker.keytab", "target/test-classes/kerberos/kafkabroker.keytab"); | |||
There was a problem hiding this comment.
just checking my mental model. this part is unrelated to the test instability. you are just preventing the test run dirtying the source tree.
k-wall
approved these changes
Dec 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change KerberosContainer wait strategy from log to 88 port listen
Remove keytabs created in test-resources, the test now copies them to the target/test-classes/kerberos dir.
Fixes #121