Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OAuth2DataLoader doesn't handle refresh token #184

Closed
RemiGuyon opened this issue Feb 20, 2017 · 3 comments
Closed

OAuth2DataLoader doesn't handle refresh token #184

RemiGuyon opened this issue Feb 20, 2017 · 3 comments
Labels
bug

Comments

@RemiGuyon
Copy link

I am using OAuth2DataLoader to handle the authorization logic.
But then I saw that if I get a 401, tokens are forgotten just before calling authorize. This makes the whole refresh token process useless with OAuth2DataLoader.
I don't get why the tokens have to be forgotten here. Am I missing something?
p2 added a commit that referenced this issue Feb 21, 2017
@p2
Don’t forget refresh tokens in data loader
840d6ea 
Only throw away access token, let `OAuth2` base class throw away refresh token if it’s rejected. Concerns #184 .
@p2
Copy link
Owner

p2 commented Feb 21, 2017

You're right of course! I have just pushed a small change, have yet to test if that's a good solution. Can you give master branch a shot?

@p2 p2 added the bug label Feb 21, 2017
@RemiGuyon
Copy link
Author

Thanks for the update! I just tried the master branch but KeychainGenericPasswordType is not found anymore.

@p2
Copy link
Owner

p2 commented Feb 22, 2017 •
edited
Loading

Do a git submodule update --init if you haven't already.

@p2 p2 closed this as completed Feb 28, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@p2 @RemiGuyon