Skip to content

Commit

Permalink
fixup! fix: Drop pending finalize messages on disconnected peer
Browse files Browse the repository at this point in the history
The reconnect logic for a subchannel in the state of CloseConfirmed does not revert to an CloseOffered state, so that dropping the `CloseFinalize` message upon channel reestablishment turns out to be a regression. I haven't looked into the details, but I am wondering why the counter state is considered for the reconnect handling in the close protocol and not in the open protocol.
  • Loading branch information
holzeis committed Aug 24, 2023
1 parent f10b91f commit 2fb07ae
Showing 1 changed file with 0 additions and 10 deletions.
10 changes: 0 additions & 10 deletions dlc-messages/src/message_handler.rs
Original file line number Diff line number Diff line change
Expand Up @@ -137,16 +137,6 @@ impl MessageHandler {
);
false
}
Message::SubChannel(SubChannelMessage::CloseFinalize(message))
if node_id == disconnected_node_id =>
{
log::warn!(
"Dropping SubChannelCloseFinalize message for channel {:?} \
after peer {node_id} disconnected",
message.channel_id
);
false
}
// Keep any other message
_ => true,
}
Expand Down

0 comments on commit 2fb07ae

Please sign in to comment.