Log deser errors when getting all channels/contracts #126
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before this patch we were immediately failing the entire call to `get_contracts` or `get_sub_channels` in the event of encountering a single deserialisation failure. This can be problematic if we introduce breaking changes and consumers keep around incompatible data.
Tibo-lg
approved these changes
Jul 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this patch we were immediately failing the entire call to
get_contractsorget_sub_channelsin the event of encountering a single deserialisation failure. This can be problematic if we introduce breaking changes and consumers keep around incompatible data.We absolutely don't need to merge this if you think it's too much, @Tibo-lg. In practice, this is a mandatory patch for us at 10101. It's kind of nice to be able to be resilient against these things and it's probably okay since
dlc-sled-storage-provideris kind of a utility crate.