Support no-std

[benthecarman]

Should allow for no-std libraries to use rust-dlc

[benthecarman]

Doesn't seem to be fully working yet..

[benthecarman]

building works correctly, can't seem to get it to work correctly with the correct dev-dependecies, not too sure what I am doing wrong

[Tibo-lg]

building works correctly, can't seem to get it to work correctly with the correct dev-dependecies, not too sure what I am doing wrong

The dlc crate doesn't build for me (running cargo build --features=no-std). I get an error on miniscript.

[benthecarman]

Should be a lot closer now, just need to get dlc-manager working. There are a lot of test dependencies that rely on bitcoin/std so will need to figure out a way around that.

Looks like also unit test CI fails because we can't enable std and no-std together so the all-features flag doesn't work

[benthecarman]

So seems the only way to get dlc-manager working with no-std would be to move the tests into another crate, which is kinda ugly.

[Tibo-lg]

So seems the only way to get dlc-manager working with no-std would be to move the tests into another crate, which is kinda ugly.

I'm still having the same issue with miniscript in the dlc crate (which also seem to be the error that occur on CI). Is there more to it than running cargo build --features=no-std?

[benthecarman]

I'm still having the same issue with miniscript in the dlc crate (which also seem to be the error that occur on CI). Is there more to it than running cargo build --features=no-std?

you need to disable default features as well

cargo build --no-default-features --features no-std

if that still doesn't work you might need to do a cargo clean

[Tibo-lg]

you need to disable default features as well

cargo build --no-default-features --features no-std

Thanks that worked! But yeah not sure what's the best solution, having tests in a separate crate is definitely not great. Maybe some weird feature flag fu could do it?

[benthecarman]

This should be ready after #145

dlc-manager doesn't have explicit support for no-std but not the end of the world, it should still work when used as a library.

[Tibo-lg]

Great work thanks! Just a couple of nits and to understand the reasons for some features.

[Tibo-lg]

I think this is unnecessary?

[benthecarman]

Yeah I've never had to use this before but I couldn't get it to work without it. Seems like rust-miniscript does it as well so maybe it is just required for this crate?

[benthecarman]

Fixed the unnecessary features, good call out!

[Tibo-lg]

Fixed the unnecessary features, good call out!

Actually seems like the rand-std feature of secp256k1-zkp is required to access the EcdsaAdaptorSignature::encrypt function because it uses thread_rng. Solution is either use an prng that works with no-std and use encrypt_with_rng, or use encrypt_no_aux_rand (ideally it'd be best to do that only for the no-std feature). I'm confused that this did not show up before.

[benthecarman]

@Tibo-lg sorry totally missed your comment. I made it so when we are not std that it uses encrypt_no_aux_rand!

[Tibo-lg]

@Tibo-lg sorry totally missed your comment. I made it so when we are not std that it uses encrypt_no_aux_rand!

Perfect! One last thing, could you apply this patch to cleanup unnecessary features? (I couldn't push to your branch)
8f5fe5e

[Tibo-lg]

Thanks!