Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add publishing workflow #6

Merged
merged 5 commits into from
Oct 25, 2023
Merged

Add publishing workflow #6

merged 5 commits into from
Oct 25, 2023

Conversation

danyalaytekin
Copy link
Member

@danyalaytekin danyalaytekin commented Oct 20, 2023 •
edited
Loading

This PR brings package publishing into GitHub Actions.

  • Retains a manual trigger
    • A GitHub Release
    • workflow_dispatch
  • Will be published by pa11y-bot

Effects:

  • Dry run publish triggered on:
  • Full publish triggered on:
    • Release published
    • Manual triggered with Dry run only unticked

Also:

  • remove master as push trigger target for tests

Remaining tasks

  • Complete setup at npmjs.org
  • Add publishing key secret to this repo
  • Refactor to extract --dry-run

@danyalaytekin danyalaytekin changed the title [Draft] Add publishing workflow (dry run) [Draft] Add publishing workflow Oct 25, 2023
@danyalaytekin danyalaytekin changed the title [Draft] Add publishing workflow Add publishing workflow Oct 25, 2023
@danyalaytekin danyalaytekin marked this pull request as ready for review October 25, 2023 14:30
hollsk
hollsk approved these changes Oct 25, 2023
View reviewed changes
Copy link
Member

@hollsk hollsk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@danyalaytekin danyalaytekin merged commit 44b2ec5 into main Oct 25, 2023
2 checks passed
@danyalaytekin danyalaytekin deleted the publishing-mechanism branch October 25, 2023 14:50
This was referenced Oct 26, 2023
Merged
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hollsk hollsk hollsk approved these changes

@jpw jpw Awaiting requested review from jpw

@josebolos josebolos Awaiting requested review from josebolos

Assignees
No one assigned
Labels
type: enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@danyalaytekin @hollsk