Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix GitHub Actions build #105

Merged
merged 6 commits into from
Oct 4, 2023

Conversation

danyalaytekin
Copy link
Member

@danyalaytekin danyalaytekin commented Sep 27, 2023

This pull request mainly fixes the build and introduces me to Pa11y PR creation.

  1. Fixes the make test step of the GitHub Actions check checkout_and_test which had stopped working recently because of the Ubuntu issue currently affecting pa11y-ci. It does this by regressing the image from ubuntu-latest to ubuntu-20.04. Soon ubuntu-latest will return.
  2. Makes several other tiny changes, some of which emerged primarily to bump the build, but which hopefully remain useful:
    1. Recommend a VS Code extension for make
    2. Add .nvmrc and set to same Node.js version as the CI check
    3. Make one instance of the copyright year current; republishing should fix the other instance
    4. Improve consistency where we mention GitHub and GitHub Issues

If the PR is approved I also plan to rename master to main a moment before merging it. This is part of verifying this renaming process before extending it to repos which have more consumers, and in this repo's case it will also republish the site, immediately after it is unpublished by the change of name.

@danyalaytekin danyalaytekin self-assigned this Sep 27, 2023
@danyalaytekin danyalaytekin marked this pull request as ready for review October 3, 2023 16:55
@danyalaytekin danyalaytekin changed the title [WIP, DNR] Update developer experience during familiarisation Fix GitHub Actions build Oct 3, 2023
Copy link

@jpw jpw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you.

@danyalaytekin
Copy link
Member Author

danyalaytekin commented Oct 4, 2023

Renaming mastermain now for:

@danyalaytekin
Copy link
Member Author

danyalaytekin commented Oct 4, 2023

Renaming took GitHub about a minute and has not actually unpublished https://pa11y.org (yet?). Let's see whether the workflow's mention of master will map to main after the merge. There doesn't seem to be a variable like {{ github.default_branch }} that would work in the on: section of a workflow.

Update: renaming the default branch triggered its own republish.

GitHub's advisories before renaming

GitHub's advisories before renaming (will update PRs, branch protection rule, will unpublish site, will not update clones)

GitHub's notice once in progress

'Branch master will be renamed to main shortly

GitHub's notice once complete

GitHub's advice about how to update a local clone

@danyalaytekin danyalaytekin merged commit e69a612 into main Oct 4, 2023
1 check passed
@danyalaytekin danyalaytekin deleted the update-devex-as-part-of-my-familiarisation branch October 4, 2023 09:26
@danyalaytekin
Copy link
Member Author

Let's see whether the workflow's mention of master will map to main after the merge

It hasn't, so build_and_test hasn't run yet on main. Will create another PR for this, and it's good to know about for the other repos. We can use a temporary on: push: branches: [master, main].

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants