feat: add python 3.12 support #422
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
is aiohttp the only dep that needs to be upgraded to support 3.12? Why/where do we use it in the production code? |
|
Technically, both
|
JP-Ellis
force-pushed
the
feat/python-312
branch
3 times, most recently
from
b1cd0dc
to
1c90b64
Compare
JP-Ellis
added
type:feature
JP-Ellis
force-pushed
the
feat/python-312
branch
from
1c90b64
to
ebfdee2
Compare
Update the build scripts to test and target Python 3.12 released on 2 October 2023. As the dependency on distutils has been removed already, there are no other changes required. Signed-off-by: JP-Ellis <josh@jpellis.me>
JP-Ellis
force-pushed
the
feat/python-312
branch
from
ebfdee2
to
38e1138
Compare
This will help with debugging any errors that might occur during the venv setup. Signed-off-by: JP-Ellis <josh@jpellis.me>
We require the test matrix to succeed before a PR can be merged. Unfortunately, the rule is rather complex as it has to test that each element of the test matrix completed successfully. By adding another step which runs only of the matrix succeeded, we can check that this ran, as opposed to each element of the matrix. Signed-off-by: JP-Ellis <josh@jpellis.me>
JP-Ellis
force-pushed
the
feat/python-312
branch
from
28870ed
to
75542d9
Compare
|
Is there any chance that there will be a release of pact-python with this python 3.12 support included? We are now faced with a choice to downgrade to python 3.11 (and revert the nice type syntax changes) or delay adoption of Pact. |
|
We will look to get a cut released next week @logi - we want you to have your cake, and to eat it! |
|
@logi Sorry I missed your comment (I have just finished moving houses, which certainly did not help). I'll make a |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Summary
Update the build scripts to test and target Python 3.12 released on 2 October 2023. As the dependency on distutils has been removed already, there are no other changes required.
At present, this depends on a beta version of aiohttp. As a result, before this can be merged, we must wait for
🚨 Breaking Changes🔥 Motivation
As detailed in the linked issue.
🔨 Test Plan
The regular test suite will suffice. There is no change to the library code.
🔗 Related issues/PRs