chore: added v3 http interaction examples #773
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JP-Ellis
requested changes
Aug 28, 2024
There was a problem hiding this comment.
Looks good!
There's a few minor things I think should be changed to make sure that the examples serve as a good learning tool for people who are otherwise unfamiliar with Pact.
There is also a bit of a change in the provider testing which I think is needed. While Pact performs the necessary verifications on the server's communications, it would be good to show how the test can be used to verify that side-effects have (or have not) taken place within the provider's internal logic.
Let me know what you think, and if you have any questions, let me know!
JP-Ellis
force-pushed
the
updated-v3-examples
branch
from
1bd679c
to
2b835ec
Compare
JP-Ellis
approved these changes
Aug 30, 2024
JP-Ellis
force-pushed
the
updated-v3-examples
branch
from
2b835ec
to
f07de75
Compare
Also rename the files to ensure they mirror the v2 examples more closely. Signed-off-by: JP-Ellis <josh@jpellis.me>
JP-Ellis
force-pushed
the
updated-v3-examples
branch
from
f07de75
to
a05dc0a
Compare
|
There's an upstream with CFFI on Windows: Will do a force merge later today as all the other tests are fine. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Summary
This PR has example usage of Pact-python version 3 HTTP interaction
🚨 Breaking Changes
🔥 Motivation
🔨 Test Plan
🔗 Related issues/PRs