Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow optional inputs for can-i-deploy action #46

Merged
merged 1 commit into from
May 17, 2024

Conversation

jdongelmans
Copy link
Contributor

  • add retry_while_unknown and retry_interval to can-i-deploy command
  • add some validation and unit tests
  • update the README.md with example usage

See documentation here: https://docs.pact.io/pact_broker/client_cli/readme#can-i-deploy

- add retry_while_unknown and retry_interval to can-i-deploy command
- add some validation and unit tests
- update the README.md with example usage

See documentation here: https://docs.pact.io/pact_broker/client_cli/readme#can-i-deploy
@YOU54F
Copy link
Member

YOU54F commented May 17, 2024

Awesome stuff, thanks for updating the workflow inputs even though they aren't used. It would be nice to sort that #38 as you get nice IDE completion from inputs, over env vars.

@YOU54F YOU54F merged commit 3095637 into pactflow:main May 17, 2024
13 of 14 checks passed
@jdongelmans jdongelmans deleted the add-optional-retry-inputs branch May 17, 2024 23:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants