Patch 2 #25
Open
Patch 2 #25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In v0.8, non-string arguments were ignored. v0.10 throws an exception.
Otherwise it cannot be used in StreamWrap. Forgot to include in last patch, broke the build.
Fixes decoder.end() being called on every push(null). As the tls module does this, corrupt stream data could potentially be added to the end.
But they will in v0.12. Re nodejs#5005.
Commit a804347 makes fs function rethrow errors when the callback is omitted. While the right thing to do, it's a change from the old v0.8 behavior where such errors were silently ignored. To give users time to upgrade, temporarily disable that and replace it with a function that warns once about the deprecated behavior. Close nodejs#5005
This reverts commit 615d809.
Conflicts: src/node_version.h
Consider this example:
// fd 3 is a bound tcp socket
var s = net.createServer(cb);
s.listen({ fd: 3 });
console.log(s.address()); // prints null
This commit makes net.Server#address() print the actual address.
Ditto for non-listen sockets; properties like net.Socket#localAddress
and net.Socket#remoteAddress now return the correct value.
Fixes nodejs#5009.
The benefits of the hot-path optimization below start to fall off when the buffer size gets up near 128KB, because the cost of the copy is more than the cost of the extra write() call. Switch to the write/end method at that point. Heuristics and magic numbers are awful, but slow http responses are worse. Fix nodejs#4975
Updated version that does what it says without assigning state.decoder.
This was necessary when we weren't auto-starting when a 'readable' listener is added.
Also, set paused=false *before* calling resume(). Otherwise, there's an edge case where an immediately-emitted chunk might make it call pause() again incorrectly.
Setting the V8 heap at or near 0x20000000 on 32bit sunos only allows 512 MB of heap space, instead on sunos move this to 0x80000000. Fixes nodejs#4010.
Handle wide characters (such as あ, 谢, 고) as two column wide to make cursor move properly. Closes nodejs#555. Closes nodejs#4994.
Looks like a merge conflict in 77ed12f left in the old, unconditional install rule. Remove it, the new and improved rule is a few lines down. Fixes nodejs#5044.
In 0168109 an implementation of MakeCallback was accidently removed. It has been re-added.
Fix stucked CryptoStream behaviour, happening when one of the sides locks-up in queued state. fix nodejs#5023
Fix stucked CryptoStream behaviour, happening when one of the sides locks-up in queued state. fix nodejs#5023
The blog lives at blog.nodejs.org while the main website lives at nodejs.org. Ergo, use absolute URLs for links to the main website. Fixes nodejs#5062.
process.stdout isn't fully initialized yet by the time the test starts when invoked with `python tools/test.py`. Use process.stdin instead and force initialization with process.stdin.resume().
I broke dgram.Socket#bind(port, cb) almost a year ago in 332fea5 but it wasn't until today that someone complained and none of the tests caught it because they all either specify the address or omit the callback. Anyway, now it works again and does what you expect: it binds the socket to the "any" address ("0.0.0.0" for IPv4 and "::" for IPv6.)
This fixes generating the v8 contstants for dtrace on smartos
A new String was being created and returned, but was not sent through the scope.Close(), which caused it to be cleaned up before being returned.
Conflicts: src/node_os.cc
4716dc6 made assert.equal() and related functions work better by generating a better toString() from the expected, actual, and operator values passed to fail(). Unfortunately, this was accomplished by putting the generated message into the error's `name` property. When you passed in a custom error message, the error would put the custom error into `name` *and* `message`, resulting in helpful string representations like "AssertionError: Oh no: Oh no". This commit resolves that issue by storing the generated message in the `message` property while leaving the error's name alone and adding a regression test so that this doesn't pop back up later. Closes nodejs#5292.
V8 was upgraded to 3.18 in commit 9f68226. The knobs that control the ARM build have changed in a number of ways. This commit patches the configure script to reflect that. Should fix the Raspberry Pi build. Fixes nodejs#5329.
Switch to always use args.This() to retrieve object instance.
Allow the IPv4-mapped-as-IPv6 style address.
* V8: upgrade to 3.18.0 * uv: Upgrade to v0.11.1 * http: split into multiple separate modules (Timothy J Fontaine) * http: escape unsafe characters in request path (Ben Noordhuis) * url: Escape all unwise characters (isaacs) * build: depend on v8 postmortem-metadata if enabled (Paddy Byers) * etw: update prototypes to match dtrace provider (Timothy J Fontaine) * buffer: change output of Buffer.prototype.toJSON() (David Braun) * dtrace: actually use the _handle.fd value (Timothy J Fontaine) * dtrace: pass more arguments to probes (Dave Pacheco) * build: allow building with dtrace on osx (Dave Pacheco) * zlib: allow passing options to convenience methods (Kyle Robinson Young)
An absolute path will always open the same location regardless of your current working directory. For posix, this just means path.charAt(0) === '/', but on Windows it's a little more complicated. Fixes nodejs#5299.
Class property that controls the maximum number of listeners for all instances of EventEmitter. Fixes nodejs#3014. Conflicts: lib/events.js
Clean up and DRY the cluster source code. Fix a few bugs while we're here: * Short-lived handles in long-lived worker processes were never reclaimed, resulting in resource leaks. * Handles in the master process are now closed when the last worker that holds a reference to them quits. Previously, they were only closed at cluster shutdown. * The cluster object no longer exposes functions/properties that are only valid in the 'other' process, e.g. cluster.fork() is no longer exported in worker processes. So much goodness and still manages to reduce the line count from 590 to 320.
Fixes nodejs#3740 In the case of pipelined requests, you can have a situation where the socket gets destroyed via one req/res object, but then trying to destroy *another* req/res on the same socket will cause it to call undefined.destroy(), since it was already removed from that message. Add a guard to OutgoingMessage.destroy and IncomingMessage.destroy to prevent this error.
This change introduces support for the common PREFIX variable in the Makefile and install.py, instead of having /usr/local hardcoded. This makes it much easier to install node to custom locations e.g. in a user's home directory. The PREFIX variable defaults to /usr/local.
Fixes a regression that got introduced in commit ddf4d1a.
|
Can you say a bit more about what this patch is supposed to do? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.