Fix QR code resolution #15
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
List of Changes
QRCodePayloadtype to map QR code contentURLclassMotivation and Context
The main fix is to polyfill the
URLclass implementation using thereact-native-url-polyfillpackage. This is needed because of a known, unsolved bug in React Native: facebook/react-native#24428.The other change is an improvement on the mapping of QR content, which is now a structured object containing all the information parsed from the received url.
How Has This Been Tested?
Test scenario example app
Screenshots (if appropriate):
Checklist: