Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mark the Bit, Unsigned and Integer traits as 'static #171

Merged
merged 2 commits into from
Apr 21, 2021
Merged

Mark the Bit, Unsigned and Integer traits as 'static #171

merged 2 commits into from
Apr 21, 2021

Conversation

tspiteri
Copy link
Contributor

Closes #170.

@tspiteri
Copy link
Contributor Author

While adding 'static, I found that Bit and Unsigned both have Copy + Default supertraits but Integer does not. Does it make sense to also add Copy + Default to Integer for consistency, or was the omission intentional?

@paholg
Copy link
Owner

paholg commented Apr 21, 2021

It was not intentional. That would be appreciated!

@tspiteri
Copy link
Contributor Author

Done.

@paholg paholg merged commit c4e2d5c into paholg:main Apr 21, 2021
@paholg
Copy link
Owner

paholg commented Apr 21, 2021

Thanks!

@tspiteri tspiteri deleted the static-markers branch April 21, 2021 16:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Marking Unsigned as 'static
2 participants
@tspiteri @paholg