[ASTS] Two Task Runnables: Prototype #7211
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeremyk-91
commented
Aug 27, 2024
| sweepTimestampForIteration, | ||
| SweepQueueUtils.minTsForFinePartition(sweepableBucket.bucketIdentifier() + 1)); | ||
|
|
||
| // TODO (jkong): Don't just use this, it does a lot of unnecessary stuff |
There was a problem hiding this comment.
The intention here was because buckets used to be perfectly aligned on partition boundaries. This is no longer the case, and so this is necessary
jeremyk-91
force-pushed
the
jkong/bucket-storage-vi
branch
2 times, most recently
from
08f3e1a
to
4122a98
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is just a prototype. It has a sketch of the implementations for
DefaultSingleBucketSweepTask), BUT NOT any of the infrastructure around the orchestration or scheduling of instances of the taskDefaultGlobalSweepProgressUpdatingTask), again nothing that runs it.It has no tests 😬 Obviously, we'll add this when merging the PRs more concretely.
I thought this was a good way to flesh out some of the designs discussed on the RFCs.
I am not filling in the template, as this PR is not intended to be merged in its current form.