-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Immutable commit timestamp and delayed writes. And other bits. Version 1 #7216
Draft
jkozlowski
wants to merge
1
commit into
develop
Choose a base branch
from
jakubk/commit-timestamp-lock
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Generate changelog in
|
jkozlowski
force-pushed
the
jakubk/commit-timestamp-lock
branch
17 times, most recently
from
August 6, 2024 09:48
81a9701
to
3655907
Compare
ergo14
approved these changes
Aug 6, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
for RC only
jkozlowski
force-pushed
the
jakubk/commit-timestamp-lock
branch
3 times, most recently
from
August 6, 2024 13:41
897d00a
to
b0b2e4b
Compare
👍🏻 |
jkozlowski
force-pushed
the
jakubk/commit-timestamp-lock
branch
5 times, most recently
from
August 12, 2024 12:43
2a77068
to
6e0ed9b
Compare
jkozlowski
force-pushed
the
jakubk/commit-timestamp-lock
branch
11 times, most recently
from
August 22, 2024 13:10
49bcd2b
to
e81bfa6
Compare
jkozlowski
force-pushed
the
jakubk/commit-timestamp-lock
branch
from
August 22, 2024 18:22
55fe367
to
2d78843
Compare
seif-s3
force-pushed
the
jakubk/commit-timestamp-lock
branch
from
September 2, 2024 19:16
9bc5b0a
to
d649f75
Compare
jkozlowski
force-pushed
the
jakubk/commit-timestamp-lock
branch
12 times, most recently
from
September 9, 2024 12:16
5e15e22
to
cee73a6
Compare
jkozlowski
changed the title
[WIP] Immutable commit timestamp and delayed writes.
[WIP] Immutable commit timestamp and delayed writes. Version 1
Sep 17, 2024
jkozlowski
changed the title
[WIP] Immutable commit timestamp and delayed writes. Version 1
[WIP] Immutable commit timestamp and delayed writes. And other bits. Version 1
Sep 17, 2024
jkozlowski
force-pushed
the
jakubk/commit-timestamp-lock
branch
from
September 17, 2024 11:44
f07c2a3
to
d02ba22
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
General
Before this PR:
After this PR:
==COMMIT_MSG==
==COMMIT_MSG==
Priority:
Concerns / possible downsides (what feedback would you like?):
Is documentation needed?:
Compatibility
Does this PR create any API breaks (e.g. at the Java or HTTP layers) - if so, do we have compatibility?:
Does this PR change the persisted format of any data - if so, do we have forward and backward compatibility?:
The code in this PR may be part of a blue-green deploy. Can upgrades from previous versions safely coexist? (Consider restarts of blue or green nodes.):
Does this PR rely on statements being true about other products at a deployment - if so, do we have correct product dependencies on these products (or other ways of verifying that these statements are true)?:
Does this PR need a schema migration?
Testing and Correctness
What, if any, assumptions are made about the current state of the world? If they change over time, how will we find out?:
What was existing testing like? What have you done to improve it?:
If this PR contains complex concurrent or asynchronous code, is it correct? The onus is on the PR writer to demonstrate this.:
If this PR involves acquiring locks or other shared resources, how do we ensure that these are always released?:
Execution
How would I tell this PR works in production? (Metrics, logs, etc.):
Has the safety of all log arguments been decided correctly?:
Will this change significantly affect our spending on metrics or logs?:
How would I tell that this PR does not work in production? (monitors, etc.):
If this PR does not work as expected, how do I fix that state? Would rollback be straightforward?:
If the above plan is more complex than “recall and rollback”, please tag the support PoC here (if it is the end of the week, tag both the current and next PoC):
Scale
Would this PR be expected to pose a risk at scale? Think of the shopping product at our largest stack.:
Would this PR be expected to perform a large number of database calls, and/or expensive database calls (e.g., row range scans, concurrent CAS)?:
Would this PR ever, with time and scale, become the wrong thing to do - and if so, how would we know that we need to do something differently?:
Development Process
Where should we start reviewing?:
If this PR is in excess of 500 lines excluding versions lock-files, why does it not make sense to split it?:
Please tag any other people who should be aware of this PR:
@jeremyk-91
@sverma30
@raiju