Improve index conflict handler validation #7296
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pkoenig10
commented
Sep 19, 2024
| @@ -292,10 +292,10 @@ public void validate() { | |||
| "In index, a component derived from column must reference an existing column"); | |||
| } | |||
|
|
|||
| if (indexMetadata.getIndexType().equals(IndexType.CELL_REFERENCING)) { | |||
| if (!indexMetadata.getIndexType().equals(IndexType.ADDITIVE)) { | |||
There was a problem hiding this comment.
This condition is equivalent, but now it:
- Matches the framing of the error message.
- Is restrictive by default, providing additional protection if we introduce a new
IndexTypein the future.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AtlasDB does not allow schemas with a cell-referencing index whose primary table uses a conflict handler that checks for write-write conflicts but is not specifically
RETRY_WRITE_WRITE(for example,SERIALIZABLE).We don't need to require
RETRY_WRITE_WRITEspecifically, we just want to make sure that write-write conflicts are checked.