Skip to content
This repository has been archived by the owner on Mar 25, 2021. It is now read-only.

Remove unnecessary break in switchDefault example #4650

Merged
merged 1 commit into from
Apr 13, 2019

Conversation

rarenal
Copy link
Contributor

@rarenal rarenal commented Apr 9, 2019

PR checklist

  • Addresses an existing issue: fixes #0000
  • New feature, bugfix, or enhancement
  • Includes tests
  • Documentation update

Overview of change:

Last switch case does not need a break statement as the switch will already end after it. This way this example will also ensure following the rule switchFinalBreakRule which it does not at the moment.

Is there anything you'd like reviewers to focus on?

CHANGELOG.md entry:

[documentation] Fix code example for switch-default rule

Last switch case does not need a break statement as it is already the switch will already end after it. This way this example will also ensure following the rule switchFinalBreakRule.
@palantirtech
Copy link
Member

Thanks for your interest in palantir/tslint, @rarenal! Before we can accept your pull request, you need to sign our contributor license agreement - just visit https://cla.palantir.com/ and follow the instructions. Once you sign, I'll automatically update this pull request.

Copy link
Contributor

@JoshuaKGoldberg JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😄 thanks @rarenal!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants