Skip to content
This repository has been archived by the owner on Mar 25, 2021. It is now read-only.

fix identifer to identifier typo - note missing (i) #4657

Merged
merged 1 commit into from
Apr 13, 2019

Conversation

postama
Copy link
Contributor

@postama postama commented Apr 12, 2019

PR checklist

  • Addresses an existing issue: fixes #0000
  • New feature, bugfix, or enhancement
  • Includes tests
  • Documentation update

Overview of change:

This should have no functional impact, just fixing a typo in code and documentation

Is there anything you'd like reviewers to focus on?

The parameter name is limited to the scope of the function in which it is used, and therefore it is not possible to have a side effect with this change. Please confirm my understanding.

CHANGELOG.md entry:

[documentation] Fix "identifer" typo in custom rules docs

@palantirtech
Copy link
Member

Thanks for your interest in palantir/tslint, @postama! Before we can accept your pull request, you need to sign our contributor license agreement - just visit https://cla.palantir.com/ and follow the instructions. Once you sign, I'll automatically update this pull request.

Copy link
Contributor

@JoshuaKGoldberg JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😄 good catch, thanks @postama!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants