Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix range for Markupsafe #1588

Closed
wants to merge 1 commit into from
Closed

Conversation

ivan2angelov
Copy link

https://markupsafe.palletsprojects.com/en/2.1.x/changes/
"Remove soft_unicode, which was previously deprecated. Use soft_str instead. #261"

  • fixes #

Checklist:

  • Add tests that demonstrate the correct behavior of the change. Tests should fail without the change.
  • Add or update relevant docs, in the docs folder and in code.
  • Add an entry in CHANGES.rst summarizing the change and linking to the issue.
  • Add .. versionchanged:: entries in any relevant code docs.
  • Run pre-commit hooks and fix any issues.
  • Run pytest and tox, no tests failed.

https://markupsafe.palletsprojects.com/en/2.1.x/changes/
"Remove soft_unicode, which was previously deprecated. Use soft_str instead. pallets#261"
@PhotoTeeborChoka
Copy link

PhotoTeeborChoka commented Feb 18, 2022

Fix #1587 , highly appreciated as it fixes the break of current deployments due to MarkupSafe latest update - it no longer has compatible API.

@ThiefMaster
Copy link
Member

ThiefMaster commented Feb 18, 2022

Besides the fact that we always recommend pinning transitive dependencies, this change isn't correct. You're pinning the version in the latest development version which works perfectly fine with 2.1...

@davidism
Copy link
Member

davidism commented Feb 18, 2022

You are using an unsupported version of the project, please update to the latest version. Additionally, please read https://hynek.me/articles/semver-will-not-save-you/, then use a tool like pip-tools to pin your dependencies and control when you get updates. Be sure to run your tests with deprecation warnings treated as errors so that you get notified of these types of changes early.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 5, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants