Skip to content

Commit

Permalink
Merge pull request #3 from panga/jdk11
Browse files Browse the repository at this point in the history
Migrate to JDK 11
  • Loading branch information
panga committed Jul 31, 2018
2 parents 9a33380 + bb9d95f commit 62fb6aa
Show file tree
Hide file tree
Showing 6 changed files with 45 additions and 27 deletions.
44 changes: 27 additions & 17 deletions pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,9 @@
<properties>

<!-- Generic properties -->
<java.version>10</java.version>
<java.version>11</java.version>
<maven.compiler.source>${java.version}</maven.compiler.source>
<maven.compiler.target>${java.version}</maven.compiler.target>
<project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>
<project.reporting.outputEncoding>UTF-8</project.reporting.outputEncoding>

Expand Down Expand Up @@ -114,21 +116,10 @@
<optional>true</optional>
</dependency>

<dependency>
<groupId>javax.xml.bind</groupId>
<artifactId>jaxb-api</artifactId>
<version>2.3.0</version>
</dependency>
<dependency>
<groupId>org.glassfish.jaxb</groupId>
<artifactId>jaxb-runtime</artifactId>
<version>2.3.0</version>
<scope>runtime</scope>
</dependency>
<dependency>
<groupId>javax.activation</groupId>
<artifactId>javax.activation-api</artifactId>
<version>1.2.0</version>
<version>2.4.0-b180608.0325</version>
</dependency>
<dependency>
<groupId>org.hibernate.javax.persistence</groupId>
Expand All @@ -140,6 +131,17 @@
<artifactId>jboss-transaction-api_1.2_spec</artifactId>
<version>1.1.1.Final</version>
</dependency>
<dependency>
<groupId>org.javassist</groupId>
<artifactId>javassist</artifactId>
<version>3.23.1-GA</version>
</dependency>
<dependency>
<groupId>org.mockito</groupId>
<artifactId>mockito-core</artifactId>
<version>2.20.0</version>
<scope>test</scope>
</dependency>
</dependencies>

<build>
Expand All @@ -155,7 +157,7 @@
<dependency>
<groupId>org.ow2.asm</groupId>
<artifactId>asm</artifactId>
<version>6.1.1</version>
<version>6.2</version>
</dependency>
</dependencies>
</plugin>
Expand All @@ -169,7 +171,7 @@
<dependency>
<groupId>org.ow2.asm</groupId>
<artifactId>asm</artifactId>
<version>6.1.1</version>
<version>6.2</version>
</dependency>
</dependencies>
</plugin>
Expand All @@ -186,7 +188,7 @@
<configuration>
<outputDirectory>${project.build.directory}/modules</outputDirectory>
<includeScope>runtime</includeScope>
<excludeArtifactIds>spring-boot-devtools,jaxb-api,jaxb-core,jaxb-runtime</excludeArtifactIds>
<excludeArtifactIds>spring-boot-devtools</excludeArtifactIds>
</configuration>
</execution>
</executions>
Expand Down Expand Up @@ -270,7 +272,7 @@
<dependency>
<groupId>org.mockito</groupId>
<artifactId>mockito-core</artifactId>
<version>2.18.0</version>
<version>2.20.0</version>
</dependency>
</dependencies>
</plugin>
Expand Down Expand Up @@ -383,4 +385,12 @@
</license>
</licenses>

<repositories>
<repository>
<id>jvnet-nexus-staging</id>
<url>http://maven.java.net/content/repositories/staging/</url>
<layout>default</layout>
</repository>
</repositories>

</project>
2 changes: 1 addition & 1 deletion src/main/docker/Dockerfile
2 changes: 1 addition & 1 deletion src/main/docker/Dockerfile.fatjar
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
FROM openjdk:10.0.1-jre-slim
FROM openjdk:11-jre-slim

ADD spring-petclinic-2.0.0.BUILD-SNAPSHOT.jar app.jar

Expand Down
11 changes: 7 additions & 4 deletions src/main/docker/Dockerfile.glibc
Original file line number Diff line number Diff line change
@@ -1,15 +1,15 @@
FROM openjdk:10.0.1 as builder
FROM openjdk:11 as builder

RUN jlink \
--add-modules java.xml.bind,java.sql,java.naming,java.management,java.instrument,java.security.jgss \
--add-modules java.sql,java.naming,java.management,java.instrument,java.security.jgss,java.desktop,jdk.unsupported \
--verbose \
--strip-debug \
--compress 2 \
--no-header-files \
--no-man-pages \
--output /opt/jre-minimal

FROM panga/alpine:3.7-glibc2.25
FROM panga/alpine:3.8-glibc2.27

COPY --from=builder /opt/jre-minimal /opt/jre-minimal

Expand All @@ -21,4 +21,7 @@ ADD modules /opt/app/modules
ARG JVM_OPTS
ENV JVM_OPTS=${JVM_OPTS}

CMD java ${JVM_OPTS} --upgrade-module-path /opt/app/modules --module spring.petclinic
CMD java ${JVM_OPTS} \
--add-opens java.base/java.lang=spring.core,javassist \
--module-path /opt/app/modules \
--module spring.petclinic
11 changes: 7 additions & 4 deletions src/main/docker/Dockerfile.musl
Original file line number Diff line number Diff line change
@@ -1,15 +1,15 @@
FROM panga/openjdk10:jdk-alpine as builder
FROM panga/openjdk-alpine:11-jdk as builder

RUN jlink \
--add-modules java.xml.bind,java.sql,java.naming,java.management,java.instrument,java.security.jgss \
--add-modules java.sql,java.naming,java.management,java.instrument,java.security.jgss,java.desktop,jdk.unsupported \
--verbose \
--strip-debug \
--compress 2 \
--no-header-files \
--no-man-pages \
--output /opt/jre-minimal

FROM alpine:3.7
FROM alpine:3.8

COPY --from=builder /opt/jre-minimal /opt/jre-minimal

Expand All @@ -21,4 +21,7 @@ ADD modules /opt/app/modules
ARG JVM_OPTS
ENV JVM_OPTS=${JVM_OPTS}

CMD java ${JVM_OPTS} --upgrade-module-path /opt/app/modules --module spring.petclinic
CMD java ${JVM_OPTS} \
--add-opens java.base/java.lang=spring.core,javassist \
--module-path /opt/app/modules \
--module spring.petclinic
2 changes: 2 additions & 0 deletions src/main/java/module-info.java
Original file line number Diff line number Diff line change
Expand Up @@ -21,4 +21,6 @@
requires spring.tx;
requires spring.web;
requires spring.webmvc;

requires jdk.unsupported;
}

0 comments on commit 62fb6aa

Please sign in to comment.