Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add winprop to select space for new window #950

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from

Conversation

Lythenas
Copy link
Collaborator

@Lythenas Lythenas commented Sep 24, 2024

Fixes #949

This adds a new winprop that allows selecting the space a new window should be inserted.

Screenshot From 2024-09-24 12-00-30

I added a dropdown to select the workspace. Not sure if that may cause problems with dynamic workspaces etc. Maybe the simple textbox was better. If so, we can simply revert the last commit.

Note: Sometimes it feels a bit confusing because you don't see anything happening if a window opens on another workspace. E.g. on firefox if you drag a tab out of the window to create a new window it is simply gone. But I think that is kind of expected for this. Maybe adding another option to automatically switch to the workspace and focus the window would be good.

@Lythenas Lythenas marked this pull request as ready for review September 24, 2024 10:02
@jtaala
Copy link
Collaborator

jtaala commented Sep 24, 2024

Nice work @Lythenas!

I think activating the window would be the natural/expected behaviour - especially when starting a new app.

@jtaala
Copy link
Collaborator

jtaala commented Sep 24, 2024

I'm seeing some visual errors on windows that are inserted into a non-active space (i.e. when switching to the space). Might just be due to injecting windows in a way that's a little non-standard.

I'll dig into it a bit on the weekend. Another approach might just be to activate / switch to the space (and make sure it's active) at the insert stage.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants