Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Allow missing docs for test modules #10893

Merged
merged 1 commit into from
Sep 13, 2024
Merged

Fix: Allow missing docs for test modules #10893

merged 1 commit into from
Sep 13, 2024

Conversation

Abhishekkochar
Copy link
Contributor

@Abhishekkochar Abhishekkochar commented Sep 13, 2024 •
edited
Loading

Fixes: #10827

mattsse
mattsse approved these changes Sep 13, 2024
View reviewed changes
Copy link
Collaborator

@mattsse mattsse left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

progress

next step is to unpin nightly in ci and get the clippy job passing.

we can do this in this pr or separately

@mattsse mattsse added the C-debt Refactor of code section that is hard to understand or maintain label Sep 13, 2024
@mattsse mattsse added this pull request to the merge queue Sep 13, 2024
Merged via the queue into paradigmxyz:main with commit c6359b6 Sep 13, 2024
35 checks passed
@Abhishekkochar Abhishekkochar mentioned this pull request Sep 14, 2024
Open
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattsse mattsse mattsse approved these changes

@rakita rakita Awaiting requested review from rakita rakita is a code owner

@shekhirin shekhirin Awaiting requested review from shekhirin shekhirin is a code owner

@Rjected Rjected Awaiting requested review from Rjected Rjected is a code owner

@emhane emhane Awaiting requested review from emhane emhane is a code owner

@onbjerg onbjerg Awaiting requested review from onbjerg onbjerg is a code owner

Assignees
No one assigned
Labels
C-debt Refactor of code section that is hard to understand or maintain
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix new test clippy lints
2 participants
@Abhishekkochar @mattsse