Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Comment TransactionsManager #6651

Merged
merged 9 commits into from
Mar 4, 2024
Merged

Comment TransactionsManager #6651

merged 9 commits into from
Mar 4, 2024

Conversation

emhane
Copy link
Member

@emhane emhane commented Feb 18, 2024

Adds comments about the program's flow when TransactionsManager is polled

@emhane emhane added C-docs An addition or correction to our documentation A-networking Related to networking in general labels Feb 18, 2024
@emhane emhane mentioned this pull request Feb 18, 2024
Closed
mattsse
mattsse reviewed Feb 18, 2024
View reviewed changes
crates/net/network/src/transactions/mod.rs Outdated Show resolved Hide resolved
crates/net/network/src/transactions/mod.rs Outdated Show resolved Hide resolved
crates/net/network/src/transactions/mod.rs Outdated Show resolved Hide resolved
@emhane emhane requested a review from mattsse February 18, 2024 14:53
mattsse
mattsse requested changes Feb 21, 2024
View reviewed changes
Copy link
Collaborator

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

revisted this again and suggesting a path forward.

I acknowledge that I might seem very picky on these comments.

crates/net/network/src/transactions/mod.rs Show resolved Hide resolved
crates/net/network/src/transactions/mod.rs Outdated Show resolved Hide resolved
crates/net/network/src/transactions/mod.rs Outdated Show resolved Hide resolved
crates/net/network/src/transactions/mod.rs Outdated Show resolved Hide resolved
@emhane emhane mentioned this pull request Feb 22, 2024
Closed
@emhane emhane mentioned this pull request Mar 1, 2024
Merged
@emhane emhane requested a review from shekhirin March 1, 2024 02:54
@emhane emhane added the C-debt Refactor of code section that is hard to understand or maintain label Mar 1, 2024
mattsse
mattsse approved these changes Mar 1, 2024
View reviewed changes
Copy link
Collaborator

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we get a deciding review on this, @Rjected?

It looks like @emhane and I still have different opinions on wording, though very nuanced.

I'm fine with this if @Rjected is

crates/net/network/src/transactions/mod.rs Outdated Show resolved Hide resolved
Rjected
Rjected approved these changes Mar 4, 2024
View reviewed changes
Copy link
Member

@Rjected Rjected left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this looks good to me

@emhane emhane added this pull request to the merge queue Mar 4, 2024
Merged via the queue into main with commit a792f16 Mar 4, 2024
29 checks passed
@emhane emhane deleted the emhane/document-tx-manager branch March 4, 2024 17:26