feat: Implement eth68 announcement metrics, track entries by TxType

[AbnerZheng]

Close #6524
Add Histogram to track entries number by TxType when validating announcement.

[emhane]

nice work! this is very useful. perhaps you want to implement a nice panel and add to dashboard we ship in docker when done? I can make an issue for it.

[emhane]

instead of &ValidAnnouncementData as param, can we pass a new type TxTypesCounter?

struct TxTypesCounter {
    legacy: usize,
    eip2930: usize,
    eip1559: usize,
    eip4844: usize,
}

and then have a new function that updates TxTypesCounter called from here

reth/crates/net/network/src/transactions/validation.rs

Lines 129 to 142 in 6cf9e91

	if let Some(strict_min_encoded_tx_length) = self.strict_min_encoded_tx_length(tx_type) {
	if size < strict_min_encoded_tx_length {
	debug!(target: "net::eth-wire",
	ty=ty,
	size=size,
	hash=%hash,
	strict_min_encoded_tx_length=strict_min_encoded_tx_length,
	network=%Self,
	"invalid tx size in eth68 announcement"
	);
	return ValidationOutcome::Ignore
	}
	}

?

a new instance of TxTypesCounter is then made for each eth68 announcement

[AbnerZheng]

@emhane Where would you like to put an instance of TxTypesCounter? I am a little confused about TxTypesCounter, let me know if this is not you want.

[emhane]

np. only the file with metrics and the validation file should have to change. create a new instance of TxTypesCounter here

reth/crates/net/network/src/transactions/validation.rs

Line 264 in 5475a12

pass it as parameter to should_fetch

fn should_fetch(&self, ty: u8, hash: &TxHash, size: usize, ty_counter: &mut TxTypesCounter) -> ValidationOutcome;

update it here

reth/crates/net/network/src/transactions/validation.rs

Line 164 in 5475a12

update metrics before this line

reth/crates/net/network/src/transactions/validation.rs

Line 290 in 5475a12

(

[AbnerZheng]

Thank you for your detailed instructions. Based on your guidance, it seems I should incorporate AnnouncedTxTypesMetrics as a field within EthAnnouncementFilter, rather than placing it within TransactionFetcher. PTAL again.

[emhane]

perfect, thanks!

[mattsse]

hmm, should the caller be responsible for updating this?

the update can be derived from the return value?