-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
restrict max concurrent outbound dials #6860
restrict max concurrent outbound dials #6860
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this looks pretty good!
I believe this is already complete.
I'd like to see another test case that adds a few peers
- starts all allowed pendingOut (until max_concurrent is satisfied)
- calls on_active_outgoing_established
ensures peers are now::Out
and counters are as expected
@mattsse can you please check if the test case looks good? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
last test nit
@mattsse please check. |
@mattsse please check |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm!
ty!
closes #6778