Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(net): use smallvec only if debug_assertions configed #6866

Merged
merged 2 commits into from
Feb 29, 2024

Conversation

jsvisa
Copy link
Contributor

@jsvisa jsvisa commented Feb 29, 2024

make build happy without warning

warning: unused imports: `SmallVec`, `smallvec`
  --> crates/net/network/src/transactions/fetcher.rs:20:16
   |
20 | use smallvec::{smallvec, SmallVec};
   |                ^^^^^^^^  ^^^^^^^^
   |
   = note: `#[warn(unused_imports)]` on by default

warning: unused variable: `peer_id`
    --> crates/net/network/src/transactions/fetcher.rs:1114:9
     |
1114 |         peer_id: &PeerId,
     |         ^^^^^^^ help: if this is intentional, prefix it with an underscore: `_peer_id`
     |
     = note: `#[warn(unused_variables)]` on by default

Signed-off-by: jsvisa <delweng@gmail.com>
Signed-off-by: jsvisa <delweng@gmail.com>
@@ -1111,7 +1112,7 @@ impl VerifyPooledTransactionsResponse for UnverifiedPooledTransactions {
fn verify(
self,
requested_hashes: &[TxHash],
peer_id: &PeerId,
_peer_id: &PeerId,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@emhane emhane added this pull request to the merge queue Feb 29, 2024
@emhane
Copy link
Member

emhane commented Feb 29, 2024

fyi @jsvisa there is an issue for building release in ci #6660

Merged via the queue into paradigmxyz:main with commit 8594066 Feb 29, 2024
29 checks passed
@jsvisa jsvisa deleted the transaction-debug-warning branch February 29, 2024 03:13
@jsvisa
Copy link
Contributor Author

jsvisa commented Feb 29, 2024

fyi @jsvisa there is an issue for building release in ci #6660

thanks for the info, but I didn't get the point of the link, do you want to link to #6434?

BTW, seems the debug_assertions config was not available via CI or makefile, or is there anything I'm missing.

fgimenez pushed a commit to fgimenez/reth that referenced this pull request Feb 29, 2024
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants