Skip to content
This repository has been archived by the owner on Feb 26, 2020. It is now read-only.

Use commander instead of yargs for CLI #107

Merged
merged 10 commits into from
May 15, 2018
Merged

Use commander instead of yargs for CLI #107

merged 10 commits into from
May 15, 2018

Conversation

amaury1093
Copy link
Contributor

@amaury1093 amaury1093 commented May 15, 2018

  • Less code with commander.js, and has 3x more stars on github.
  • Fix bug bundled app needed parity-ui -- --help to work, now parity-ui --help works.
  • Catch some errors when parity is already running (instead of showing the horrible error dialog).

@amaury1093 amaury1093 added A0-pleasereview Pull request needs code review. B0-patchthis Pull request should also be back-ported to the beta/stable branch(es). labels May 15, 2018
@amaury1093 amaury1093 changed the title Use commander instead of yars for CLI Use commander instead of yargs for CLI May 15, 2018
@amaury1093 amaury1093 added A8-looksgood Pull request is reviewed well. and removed A0-pleasereview Pull request needs code review. labels May 15, 2018
@amaury1093 amaury1093 merged commit 1f00d22 into master May 15, 2018
@amaury1093 amaury1093 deleted the am-commander branch May 15, 2018 15:59
amaury1093 added a commit that referenced this pull request May 15, 2018
amaury1093 added a commit that referenced this pull request May 15, 2018
* Merge #107 into beta

* Bump version to 0.2.3
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
A8-looksgood Pull request is reviewed well. B0-patchthis Pull request should also be back-ported to the beta/stable branch(es).
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants