Bump Cumulus, Polkadot, and Substrate #105
Conversation
| // Expected responses are OK. | ||
| AllowKnownQueryResponses<PolkadotXcm>, | ||
| // Subscriptions for version tracking are OK. | ||
| AllowSubscriptionsFrom<ParentOrSiblings>, |
There was a problem hiding this comment.
@KiChjang would you be able to explain what a Sibling is in the context of XCM?
There was a problem hiding this comment.
No surprise here -- siblings are MultiLocations that have the same parent, as denoted by the definition MultiLocation { parent: 1, junctions: X1(_) }. It's equivalent to locating for a file under ../*, where .. is "up one level" (meaning parent) and "*" is the wildcard operator.
| @@ -558,7 +570,7 @@ parameter_types! { | |||
| } | |||
|
|
|||
| /// No local origins on this chain are allowed to dispatch XCM sends/executions. | |||
| pub type LocalOriginToLocation = SignedToAccountId32<Origin, AccountId, RelayNetwork>; | |||
| pub type LocalOriginToLocation = (); | |||
There was a problem hiding this comment.
I guess this is something that we'll need to change for canvas.
There was a problem hiding this comment.
Yeah, we'll need to definitely revisit our XCM settings after we a) learn more about what they actually do and b) determine how we actually want to use XCM in the context of Canvas
|
@cmichi there were some small changes with the new version bump, can you take another quick look? |
|
I've tested this with |
node/src/chain_spec.rs
Outdated
| /// The ID of this Parachain as registered on the Relay Chain. | ||
| /// | ||
| /// TODO: When we register as a common good parachain this will need to change. | ||
| pub const PARA_ID: u32 = 12648430; |
There was a problem hiding this comment.
I think there is already a parachain id which @lovelaced assigned for the Rococo deployment?
There was a problem hiding this comment.
Canvas on Rococo is 1002 - and as far as I understand common good chains should have a para ID 1000 <= x < 2000.
This is ready for review, but I wouldn't merge it just yet. I haven't been able to get it
working locally with
polkadot-launchdue to an issue on the Polkadot side (paritytech/polkadot#4238).Would partially close #102.