Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

Set VERSION_DISCOVERY_QUEUE_SIZE upstream. #695

Closed
nuke-web3 opened this issue Oct 22, 2021 · 1 comment
Closed

Set VERSION_DISCOVERY_QUEUE_SIZE upstream. #695

nuke-web3 opened this issue Oct 22, 2021 · 1 comment

Comments

@nuke-web3
Copy link
Contributor

nuke-web3 commented Oct 22, 2021

image

As I understand it, VERSION_DISCOVERY_QUEUE_SIZE is set directly above here and the comment is left to users to understand that this applies to this type in Polkadot. The Mocks and test uses this pattern: https://github.com/paritytech/polkadot/search?q=VERSION_DISCOVERY_QUEUE_SIZE

@bkchr Are you suggesting (from the PR comment) a default is set in the pallet itself here https://github.com/paritytech/polkadot/blob/master/xcm/pallet-xcm/src/lib.rs#L121 ?
If so, how do we expose this to end users and imply it can (and when it should) be overridden?

Originally posted by @nukemandan in #690 (comment)

@nuke-web3
Copy link
Contributor Author

Overkill - not needed 😅

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant