Use safer template defaults for polkadot-v0.9.12, move to recognize, comment on Override for AdvertisedXcmVersion default
#690
Conversation
| @@ -516,7 +512,7 @@ impl pallet_xcm::Config for Runtime { | |||
| type XcmExecuteFilter = Everything; | |||
| type XcmExecutor = XcmExecutor<XcmConfig>; | |||
| type XcmTeleportFilter = Everything; | |||
| type XcmReserveTransferFilter = Everything; | |||
| type XcmReserveTransferFilter = (); | |||
There was a problem hiding this comment.
| type XcmReserveTransferFilter = (); | |
| type XcmReserveTransferFilter = Nothing; |
Wasn't there a Nothing?
There was a problem hiding this comment.
Yes, updated now in template and in rococo FYI, please quick review again
I tested to build locally & run, I did not explicitly check if behavior of these was working (no reason to think otherwise)
| type Weigher = FixedWeightBounds<UnitWeightCost, Call, MaxInstructions>; | ||
| type LocationInverter = LocationInverter<Ancestry>; | ||
| type Origin = Origin; | ||
| type Call = Call; | ||
|
|
||
| const VERSION_DISCOVERY_QUEUE_SIZE: u32 = 100; | ||
| const VERSION_DISCOVERY_QUEUE_SIZE: u32 = 100; // Override for CurrentXcmVersion default |
There was a problem hiding this comment.
This comment correct?
There was a problem hiding this comment.
This should be moved below to the AdvertisedXcmVersion?
nuke-web3
changed the title
polkadot-v0.9.12polkadot-v0.9.12, move to recognize
|
https://writingexplained.org/recognise-or-recognize-difference I think the |
| type Weigher = FixedWeightBounds<UnitWeightCost, Call, MaxInstructions>; | ||
| type LocationInverter = LocationInverter<Ancestry>; | ||
| type Origin = Origin; | ||
| type Call = Call; | ||
|
|
||
| const VERSION_DISCOVERY_QUEUE_SIZE: u32 = 100; | ||
| const VERSION_DISCOVERY_QUEUE_SIZE: u32 = 100; // Override for CurrentXcmVersion default |
There was a problem hiding this comment.
This should be moved below to the AdvertisedXcmVersion?
nuke-web3
changed the title
polkadot-v0.9.12, move to recognizepolkadot-v0.9.12, move to recognize, comment on Override for AdvertisedXcmVersion default
|
Let me know if there is any issues after this merge, and please let's still continue #683 |
* use safer defaults in template for sovereign paraobjects * Nothing trait, fix XcmTeleportFilter * rm unused traits, update rococo and template runtimes * https://writingexplained.org/recognise-or-recognize-difference * Override for AdvertisedXcmVersion default -> to match all runtimes * cargo +nightly fmt
Based on discussion & review here: https://github.com/substrate-developer-hub/substrate-parachain-template/pull/80
A start (but not a full fix) for #683 targeting
polkadot-v0.9.12release, should also be used inmasterif merged here.Please commit directly anything that you (Cumulus core team) feels should be added/amended 🙏